chore(types): separate MatcherContext, MatcherUtils and MatcherState #13141
Conversation
|
|
||
| export type MatcherFunction<Expected extends Array<unknown> = []> = | ||
| MatcherFunctionWithState<MatcherState, Expected>; | ||
| MatcherFunctionWithContext<MatcherContext, Expected>; | ||
|
|
||
| // TODO should be replaced with `MatcherFunctionWithContext` |
There was a problem hiding this comment.
@mrazauskas what is this TODO for?
There was a problem hiding this comment.
If I recall it right, MatcherFunction and MatcherFunctionWithContext does not allow any type of actual and expected values. Or so. Currently there is a need to have anys internally, but would be nicer to rework these into unknowns. After this will be done, RawMatcherFn can be replaced with MatcherFunctionWithContext.
There was a problem hiding this comment.
In other words, RawMatcherFn is redundant type, but it cannot be removed at this moment.
| @@ -41,12 +45,19 @@ export type MatchersObject = { | |||
| export type ThrowingMatcherFn = (actual: any) => void; | |||
| export type PromiseMatcherFn = (actual: any) => Promise<void>; | |||
|
|
|||
| export interface MatcherUtils { | |||
There was a problem hiding this comment.
I just extracted the fields that felt more "util-y" - should I take others?
| }; | ||
|
|
||
| const matcherContext: MatcherContext = { | ||
| ...getState<MatcherState>(), |
There was a problem hiding this comment.
explicit generic as otherwise it inferred MatcherContext and didn't error when MatcherContext where missing
SimenB
changed the title
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Inspired by DefinitelyTyped/DefinitelyTyped#61717 which differentiates.
Test plan
Green CI