Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update react-native example to 0.64 #11190

Merged
merged 1 commit into from
Mar 13, 2021
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Mar 13, 2021

Summary

Removes large chunks of our lockfile as RN has upgraded lots of stuff 🎉

I have to override the version of the cache key creator due to facebook/react-native#30637

/cc @cpojer @rickhanlonii RN 0.64 will be incompatible with Jest 27 due to this

Test plan

Green CI

@netlify
Copy link

netlify bot commented Mar 13, 2021

Deploy preview for jestjs ready!

Built without sensitive environment variables with commit 3cb32b5

https://deploy-preview-11190--jestjs.netlify.app

@SimenB SimenB merged commit 344b31a into jestjs:master Mar 13, 2021
@SimenB SimenB deleted the rn-64 branch March 13, 2021 13:55
@thymikee
Copy link
Collaborator

thymikee commented Mar 13, 2021

Yay! Requested to include your commit in a minor release when it's merged

"jest": "workspace:*",
"jest-environment-node": "workspace:*",
"react-native": "patch:react-native@0.63.2#./patches/react-native.patch"
"react-native": "patch:react-native@0.64.0#./patches/react-native.patch"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally we should get rid of this patch as well, but I haven't bothered creating an issue with RN yet 😅

@SimenB
Copy link
Member Author

SimenB commented Mar 13, 2021

https://github.blog/changelog/2021-01-25-dependency-review-beta/

fancy

image

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants