Fails to mock certain libraries #90

callum · 2014-07-16T15:20:44Z

We ran into an issue on a project where Jest borked when requiring a certain library (in this case Bluebird http://github.com/petkaantonov/bluebird).

I set up an isolated example to see if the result was the same...

I wonder if it's something to do with how Bluebird is written? I'm really not sure. We resorted to overhauling our test setup because of this.

The code: https://github.com/callum/jest-issue

Seems like it could be the same issue as #59

OscarGodson · 2014-07-16T17:48:46Z

FWIW, I ran into a similar issue like this as well with ampersand-state except an "undefined is not a function" error. Had to add it to the dont mock section in package.json

codeEmitter · 2014-08-21T20:39:10Z

Ran into similar issues with the mongoose & winston modules compounded by issue #110 which stomps on the console output when the process dies so that the errors weren't clear.

https://www.npmjs.org/package/mongoose
https://www.npmjs.org/package/winston

I understand that configuring these modules not to be mocked would get me around the exceptions, however, these are libraries that I need to mock in order to test the smallest unit of relevant code in my code base. I was hoping that jest would keep me from having to do the work of manually mocking these types of dependencies, but resorted to doing just that.

tcoopman · 2014-10-01T13:05:47Z

I have simular problems loading joi:

This happens with jest.dontMock('joi') and without it.

TypeError: c:\Workspace\synductis\test\testJest.js: c:\Workspace\synductis\node_modules\joi\index.js: c:\Workspace\synductis\node_modules\joi\lib\index.js: c:\Workspace\synductis\node_modules\joi\lib\cast.js: c:\Workspace\synductis\node_modules\joi\lib\date.js: Property 'inherits' of object [object Object] is not a function
    at c:\Workspace\synductis\node_modules\joi\lib\date.js:19:6
    at Object.runContentWithLocalBindings (c:\Workspace\synductis\node_modules\jest-cli\src\lib\utils.js:315:17)
    at Loader._execModule (c:\Workspace\synductis\node_modules\jest-cli\src\HasteModuleLoader\HasteModuleLoader.js:243:9)
    at Loader.requireModule (c:\Workspace\synductis\node_modules\jest-cli\src\HasteModuleLoader\HasteModuleLoader.js:886:12)
    at Loader._generateMock (c:\Workspace\synductis\node_modules\jest-cli\src\HasteModuleLoader\HasteModuleLoader.js:274:30)
    at Loader.requireMock (c:\Workspace\synductis\node_modules\jest-cli\src\HasteModuleLoader\HasteModuleLoader.js:790:43)
    at Loader.requireModuleOrMock (c:\Workspace\synductis\node_modules\jest-cli\src\HasteModuleLoader\HasteModuleLoader.js:905:17)
    at c:\Workspace\synductis\node_modules\joi\lib\cast.js:12:11
    at Object.runContentWithLocalBindings (c:\Workspace\synductis\node_modules\jest-cli\src\lib\utils.js:315:17)
    at Loader._execModule (c:\Workspace\synductis\node_modules\jest-cli\src\HasteModuleLoader\HasteModuleLoader.js:243:9)
    at Loader.requireModule (c:\Workspace\synductis\node_modules\jest-cli\src\HasteModuleLoader\HasteModuleLoader.js:886:12)
    at Loader._generateMock (c:\Workspace\synductis\node_modules\jest-cli\src\HasteModuleLoader\HasteModuleLoader.js:274:30)
    at Loader.requireMock (c:\Workspace\synductis\node_modules\jest-cli\src\HasteModuleLoader\HasteModuleLoader.js:790:43)
    at Loader.requireModuleOrMock (c:\Workspace\synductis\node_modules\jest-cli\src\HasteModuleLoader\HasteModuleLoader.js:905:17)
    at c:\Workspace\synductis\node_modules\joi\lib\index.js:5:12
    at Object.runContentWithLocalBindings (c:\Workspace\synductis\node_modules\jest-cli\src\lib\utils.js:315:17)
    at Loader._execModule (c:\Workspace\synductis\node_modules\jest-cli\src\HasteModuleLoader\HasteModuleLoader.js:243:9)
    at Loader.requireModule (c:\Workspace\synductis\node_modules\jest-cli\src\HasteModuleLoader\HasteModuleLoader.js:886:12)
    at Loader._generateMock (c:\Workspace\synductis\node_modules\jest-cli\src\HasteModuleLoader\HasteModuleLoader.js:274:30)
    at Loader.requireMock (c:\Workspace\synductis\node_modules\jest-cli\src\HasteModuleLoader\HasteModuleLoader.js:790:43)
    at Loader.requireModuleOrMock (c:\Workspace\synductis\node_modules\jest-cli\src\HasteModuleLoader\HasteModuleLoader.js:905:17)
    at c:\Workspace\synductis\node_modules\joi\index.js:1:85
    at Object.runContentWithLocalBindings (c:\Workspace\synductis\node_modules\jest-cli\src\lib\utils.js:315:17)
    at Loader._execModule (c:\Workspace\synductis\node_modules\jest-cli\src\HasteModuleLoader\HasteModuleLoader.js:243:9)
    at Loader.requireModule (c:\Workspace\synductis\node_modules\jest-cli\src\HasteModuleLoader\HasteModuleLoader.js:886:12)
    at Loader.requireModuleOrMock (c:\Workspace\synductis\node_modules\jest-cli\src\HasteModuleLoader\HasteModuleLoader.js:907:17)
    at c:\Workspace\synductis\test\testJest.js:4:11
    at Object.runContentWithLocalBindings (c:\Workspace\synductis\node_modules\jest-cli\src\lib\utils.js:315:17)
    at Loader._execModule (c:\Workspace\synductis\node_modules\jest-cli\src\HasteModuleLoader\HasteModuleLoader.js:243:9)
    at Loader.requireModule (c:\Workspace\synductis\node_modules\jest-cli\src\HasteModuleLoader\HasteModuleLoader.js:886:12)
    at jasmineTestRunner (c:\Workspace\synductis\node_modules\jest-cli\src\jasmineTestRunner\jasmineTestRunner.js:225:16)
    at c:\Workspace\synductis\node_modules\jest-cli\src\TestRunner.js:370:12
    at _fulfilled (c:\Workspace\synductis\node_modules\jest-cli\node_modules\q\q.js:798:54)
    at self.promiseDispatch.done (c:\Workspace\synductis\node_modules\jest-cli\node_modules\q\q.js:827:30)
    at Promise.promise.promiseDispatch (c:\Workspace\synductis\node_modules\jest-cli\node_modules\q\q.js:760:13)
    at c:\Workspace\synductis\node_modules\jest-cli\node_modules\q\q.js:574:44
    at flush (c:\Workspace\synductis\node_modules\jest-cli\node_modules\q\q.js:108:17)
    at c:\Workspace\synductis\node_modules\jest-cli\src\lib\FakeTimers.js:259:7
    at process._tickCallback (node.js:419:13)

dahjelle · 2014-10-31T16:18:16Z

I've the same problem loading the wreck module as @tcoopman, with or without dontMock.

Looking at the code for joi and for wreck, I see that the "Property 'inherits'…is not a function" bit is triggered in both cases by a call to Hoek.inherits, such as from joi source:

Hoek.inherits(internals.Date, Any);

I also tried dontMock on hoek, but that didn't change things, either.

I'm guessing the only workaround is a manual mock in here somewhere?

dahjelle · 2014-10-31T17:15:57Z

@tcoopman I was able to get wreck to mock properly after adding the following bits to my test:

jest.dontMock( "util" );
jest.dontMock( "hoek" );
jest.dontMock( "https" );
jest.dontMock( "http" );

Presumably you wouldn't need the http* lines for joi, but I'm pretty sure you'll need at least the first two lines.

dahjelle · 2014-12-22T17:20:48Z

Regarding my previous comment about mocking joi: While my mock for wreck works fine, turns out mocking joi is a completely different beast, and my suggestion above doesn't work. At the very least, I've been able to get require('joi') not to mess up my other tests (that don't use joi), but that's about it:

jest.dontMock('net');
jest.dontMock('isemail');
jest.dontMock('topo');
jest.dontMock('moment');
jest.dontMock('../../node_modules/joi/index.js');
jest.dontMock('../../node_modules/joi/lib/any.js');
jest.dontMock('../../node_modules/joi/lib/array.js');
jest.dontMock('../../node_modules/joi/lib/binary.js');
jest.dontMock('../../node_modules/joi/lib/boolean.js');
jest.dontMock('../../node_modules/joi/lib/cast.js');
jest.dontMock('../../node_modules/joi/lib/date.js');
jest.dontMock('../../node_modules/joi/lib/errors.js');
jest.dontMock('../../node_modules/joi/lib/function.js');
jest.dontMock('../../node_modules/joi/lib/index.js');
jest.dontMock('../../node_modules/joi/lib/language.js');
jest.dontMock('../../node_modules/joi/lib/number.js');
jest.dontMock('../../node_modules/joi/lib/object.js');
jest.dontMock('../../node_modules/joi/lib/ref.js');
jest.dontMock('../../node_modules/joi/lib/string.js');

Is there a cleaner way to do that?

I've tried quite a few things with dontMock and config.unmockedModulePathPatterns, but have had no success. With that code, the test errors with

 TypeError: Object [object Object] has no method 'required'

when I have Joi.string().required() in the schema.

Has anyone been successful testing code that uses joi with Jest?

cc: @tcoopman

dahjelle · 2014-12-24T03:18:12Z

FWIW, I did get joi to mock correctly. I had to add a few more dontMock's for hoek:

jest.dontMock('net');
jest.dontMock('isemail');
jest.dontMock('topo');
jest.dontMock('moment');
jest.dontMock('../../node_modules/joi/index.js');
jest.dontMock('../../node_modules/joi/lib/any.js');
jest.dontMock('../../node_modules/joi/lib/array.js');
jest.dontMock('../../node_modules/joi/lib/binary.js');
jest.dontMock('../../node_modules/joi/lib/boolean.js');
jest.dontMock('../../node_modules/joi/lib/cast.js');
jest.dontMock('../../node_modules/joi/lib/date.js');
jest.dontMock('../../node_modules/joi/lib/errors.js');
jest.dontMock('../../node_modules/joi/lib/function.js');
jest.dontMock('../../node_modules/joi/lib/index.js');
jest.dontMock('../../node_modules/joi/lib/language.js');
jest.dontMock('../../node_modules/joi/lib/number.js');
jest.dontMock('../../node_modules/joi/lib/object.js');
jest.dontMock('../../node_modules/joi/lib/ref.js');
jest.dontMock('../../node_modules/joi/lib/string.js');
jest.dontMock('../../node_modules/joi/node_modules/hoek/index.js');
jest.dontMock('../../node_modules/joi/node_modules/hoek/lib/index.js');
jest.dontMock('../../node_modules/joi/node_modules/hoek/lib/escape.js');

mondras · 2015-01-22T13:41:47Z

+1

boopathi · 2015-03-16T15:34:30Z

Getting error:

// in node_modules/bluebird/js/main/bluebird.js
Cannot set property 'noConflict' of undefined

And if I dontMock everything under bluebird, I get segmentation fault

$ jest
Using Jest CLI v0.4.0
Waiting on 1 test...Segmentation fault: 11
$

and I do this

jest
    .dontMock('bluebird')
    .dontMock('../node_modules/bluebird/js/main/any.js')
    .dontMock('../node_modules/bluebird/js/main/assert.js')
    .dontMock('../node_modules/bluebird/js/main/async.js')
    .dontMock('../node_modules/bluebird/js/main/bind.js')
    .dontMock('../node_modules/bluebird/js/main/bluebird.js')
    // ...
    .dontMock('../node_modules/bluebird/js/main/using.js')
    .dontMock('../node_modules/bluebird/js/main/util.js')

pilwon · 2015-03-31T01:20:05Z

I also have problem working with bluebird. Same error message. (related facebook/react-native#516 (comment))

amasad · 2015-03-31T23:15:12Z

FYI here is what I did to work around the problem. In my project root I have a file in __mocks__/bluebird.js

'use strict';

jest.autoMockOff();
module.exports = require.requireActual('bluebird');
jest.autoMockOn();

pilwon · 2015-04-01T00:26:11Z

@amasad Thanks, this workaround is working for me.

screendriver · 2015-06-15T12:51:27Z

@amasad workaround also worked for me 👍

ghost · 2015-08-04T18:02:09Z

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

mzratio · 2015-09-20T00:33:40Z

@amasad thank you for the workaround.

schwiet · 2015-10-23T20:02:00Z

Any update on this? I'm running into this problem when using a symlink in node_modules.

lukesneeringer · 2015-10-27T06:37:31Z

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

Could we get a response from you, please?

cpojer · 2015-10-27T17:56:06Z

Certainly! Unfortunately it is hard to auto-mock something at runtime that uses meta-programming for its implementation without ES2015 Proxies which aren't properly implemented in any engine yet. For these cases there are always two solutions:

Create a manual mock instead
Do not mock that module at all

In a lot of cases you don't actually want mocking. You probably always want an unmocked version of bluebird; there is no point in mocking a Promise library.

cpojer · 2015-10-27T17:56:58Z

The proper solution to this problem is to put "bluebird" into the "unmockedModulePathPatterns" config.

cpojer · 2016-03-03T08:51:23Z

See my last comment in #471. The documentation is also improved in #763.

github-actions · 2021-05-14T12:07:40Z

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

dundalek mentioned this issue Nov 20, 2014

Jest crashes when accessing global process object #179

Closed

dahjelle mentioned this issue Dec 24, 2014

Idea: dontMock has option to add recursively #204

Closed

pilwon mentioned this issue Mar 31, 2015

react-packager: Switch from Q to Bluebird as promises library facebook/react-native#516

Closed

pimterry mentioned this issue Nov 24, 2015

Incompatible with Jest pimterry/loglevel#85

Closed

cpojer closed this as completed Mar 3, 2016

pimterry mentioned this issue Mar 16, 2016

Automocking fails for modules containing "console.log.bind" #804

Closed

kwonoj mentioned this issue Apr 23, 2016

utils/root returns undefined in Jest ReactiveX/rxjs#1643

Closed

jy95 mentioned this issue Feb 16, 2018

TypeError: sourceMap.map.originalPositionFor is not a function #5589

Closed

colw mentioned this issue Aug 6, 2019

colw/transaction refactor luniehq/lunie#2846

Merged

5 tasks

github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fails to mock certain libraries #90

Fails to mock certain libraries #90

callum commented Jul 16, 2014

OscarGodson commented Jul 16, 2014

codeEmitter commented Aug 21, 2014

tcoopman commented Oct 1, 2014

dahjelle commented Oct 31, 2014

dahjelle commented Oct 31, 2014

dahjelle commented Dec 22, 2014

dahjelle commented Dec 24, 2014

mondras commented Jan 22, 2015

boopathi commented Mar 16, 2015

pilwon commented Mar 31, 2015

amasad commented Mar 31, 2015

pilwon commented Apr 1, 2015

screendriver commented Jun 15, 2015

ghost commented Aug 4, 2015

mzratio commented Sep 20, 2015

schwiet commented Oct 23, 2015

lukesneeringer commented Oct 27, 2015

cpojer commented Oct 27, 2015

cpojer commented Oct 27, 2015

cpojer commented Mar 3, 2016

github-actions bot commented May 14, 2021

Fails to mock certain libraries #90

Fails to mock certain libraries #90

Comments

callum commented Jul 16, 2014

OscarGodson commented Jul 16, 2014

codeEmitter commented Aug 21, 2014

tcoopman commented Oct 1, 2014

dahjelle commented Oct 31, 2014

dahjelle commented Oct 31, 2014

dahjelle commented Dec 22, 2014

dahjelle commented Dec 24, 2014

mondras commented Jan 22, 2015

boopathi commented Mar 16, 2015

pilwon commented Mar 31, 2015

amasad commented Mar 31, 2015

pilwon commented Apr 1, 2015

screendriver commented Jun 15, 2015

ghost commented Aug 4, 2015

mzratio commented Sep 20, 2015

schwiet commented Oct 23, 2015

lukesneeringer commented Oct 27, 2015

cpojer commented Oct 27, 2015

cpojer commented Oct 27, 2015

cpojer commented Mar 3, 2016

github-actions bot commented May 14, 2021