snapshot serializer fails to serialize invalid dates

[huafu]

🐛 Bug Report

expect(new Date(NaN)).toMatchSnapshot()
// will throw a RangeError: Invalid time value
//        at Date.toISOString (<anonymous>)

To Reproduce

Create a simple test with the code above

Expected behavior

Even if it sounds weird to expect a date to be invalid, it shouldn't fail to create a snapshot with an invalid one. It should serialize it as invalid-date for example (NOT NaN since we need to know that it's a date type in the snapshot).

As an example of use, I experienced this while creating tests for a serializer/deserializer where I needed to save and restore invalid dates...

Link to repl or repo (highly encouraged)

https://github.com/huafu/jest-issue-demo

Run npx envinfo --preset jest

Paste the results here:

  System:
    OS: macOS High Sierra 10.13.5
    CPU: x64 Intel(R) Core(TM) i5-4288U CPU @ 2.60GHz
  Binaries:
    Node: 10.4.0 - ~/.nvm/versions/node/v10.4.0/bin/node
    Yarn: 1.7.0 - /usr/local/bin/yarn
    npm: 6.1.0 - ~/.nvm/versions/node/v10.4.0/bin/npm
  npmPackages:
    jest: ^23.3.0 => 23.3.0

[SimenB]

Wanna send a pr for it? It's pretty-format

https://github.com/facebook/jest/blob/master/packages/pretty-format/src/index.js#L148-L150

[huafu]

Ok will do now, since I've already did a custom serializer for that in my project...

[github-actions]

This issue is stale because it has been open for 1 year with no activity. Remove stale label or comment or this will be closed in 14 days.

[github-actions]

This issue was closed because it has been stalled for 7 days with no activity. Please open a new issue if the issue is still relevant, linking to this one.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.