-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: pass config to globalSetup
and globalTeardown
#5957
Comments
Works for me, PR welcome :) |
🎉 |
@neoziro, it looks like Have you found a workaround for this? I'm currently (mis)using |
@backflip I didn't work on it for now. But yes it will be a problem for Jest Puppeteer. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I am the maintainer of Jest Puppeteer project and I would like to suggest a new feature.
When I started Jest Puppeteer I wanted to make it as simple as possible. For this purpose, I wanted to be able to configure it only using Jest config. I found
testEnvironmentOptions
, it looked like the exact use case for me.Jest Puppeteer needs
globalSetup
andglobalTeardown
, but these two methods do not have access to Jest config and by the way totestEnvironmentOptions
. This is the reason why I introducedjest-puppeteer.config.js
.Today people are complaining about that additional config.
This was the context, now the request:
Could you pass config to
globalSetup
andglobalTeardown
? I think it is as simple as modifying this line.Thanks for this amazing library!
The text was updated successfully, but these errors were encountered: