[Bug]: Inline snapshots are appending a new template literal instead of replacing existing string

[bawjensen]

Version

29.6.4

Steps to reproduce

1. Clone https://github.com/bawjensen/jest-inline-snapshot-repro
2. pnpm install
3. pnpm jest inline-snapshot.test.js --updateSnapshot (though I had to run pnpm jest inline-snapshot.test.js --updateSnapshot --prettierPath '' perhaps due to quirks in my path having prettier on it)
4. Observe the diff in inline-snapshot.test.js

Expected behavior

I see

 test("a failing inline snapshot will append, not overwrite as desired", () => {
-  expect("expected string").toMatchInlineSnapshot('"incorrect string"');
+  expect("expected string").toMatchInlineSnapshot(`"expected string"`);
 });

Actual behavior

I see

 test("a failing inline snapshot will append, not overwrite as desired", () => {
-  expect("expected string").toMatchInlineSnapshot('"incorrect string"');
+  expect("expected string").toMatchInlineSnapshot('"incorrect string"', `"expected string"`);
 });

Additional context

Our single-line template literals are being rewritten with single quotes due to our usage of the quotes eslint rule, thus we run into this issue.

I believe that I've traced the issue to

jest/packages/jest-snapshot/src/InlineSnapshots.ts

Line 277 in f2c78d0

({type}) => type === 'TemplateLiteral',

, and can confirm in my setup that patching this with

       const snapshotIndex = args.findIndex(
-        ({type}) => type === 'TemplateLiteral'
+        ({type}) => type === 'TemplateLiteral' || type === 'StringLiteral'
       );

fixes the issue. I'll be pushing up a PR soon with that proposed fix.

Environment

System:
    OS: macOS 13.5.1
    CPU: (10) x64 Apple M1 Max
  Binaries:
    Node: 16.17.1 - ~/src/coda/build/node/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 8.15.0 - ~/src/coda/build/node/bin/npm
    pnpm: 8.6.5 - ~/src/coda/build/node/bin/pnpm
  npmPackages:
    jest: ^29.6.4 => 29.6.4

[bawjensen]

From what I can tell this is the same as #10164, which was closed due to inactivity but seemed like a valid issue

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.