toHaveBeenCalledBefore throw an error

[nolazybits]

Bug

• package version: 0.7.2
• node version: 10
• npm (or yarn) version: 1.7

From the documentation example

describe("toHaveBeenCalledBefore", async () =>
{
    it('calls mock1 before mock2', () => {
      const mock1 = jest.fn();
      const mock2 = jest.fn();

      mock1();
      mock2();
      mock1();

      expect(mock1).toHaveBeenCalledBefore(mock2);
    });
}

you will get the following error

   TypeError: Cannot read property 'length' of undefined

      170 |         mock1();
      171 | 
    > 172 |         expect(mock1).toHaveBeenCalledBefore(mock2);
          |                       ^
      173 |     });
      174 | 

      at Object.<anonymous>.exports.default (../../node_modules/jest-extended/dist/matchers/toHaveBeenCalledBefore/predicate.js:9:23)
      at Object.toHaveBeenCalledBefore (../../node_modules/jest-extended/dist/matchers/toHaveBeenCalledBefore/index.js:23:42)
      at Object.<anonymous>.it (tests/unit/BugReport.test.ts:172:23)

[benjaminkay93]

Your using jest 23 right? this has been fixed in a PR that been merged in #132, However this has not yet been published, until then you will have to use either jest 22, or not use this matcher :P

[benjaminkay93]

However the docs on here do say jest 22=< so its expected to be working in jest 23, I know the docs have been updated in #132 but is it worth keeping them compatible with 22 as well?

[nolazybits]

Awesome thank you much for the feedback.
will keep an eye on the PR

Came up with a bad workaround

...
        const moduleOrder: number[] = [];
        const sut: ISauceCore = await Container.GetFromContainer(SauceCore).isReady;

        const spyModuleStart: SpyInstance = jest.spyOn(Module.prototype, "start");
        const spyModule2Start: SpyInstance = jest.spyOn(Module2.prototype, "start");
        const spyModule3Start: SpyInstance = jest.spyOn(Module3.prototype, "start");
        spyModuleStart.mockImplementation(async () =>
        {
            moduleOrder.push(1);
        });
        spyModule2Start.mockImplementation(async () =>
        {
            moduleOrder.push(2);
        });
        spyModule3Start.mockImplementation(async () =>
        {
            moduleOrder.push(3);
        });

        await sut.register(Module);
        await sut.register(Module2);
        await sut.register(Module3);
        await sut.start();

        expect(moduleOrder).toEqual(expect.arrayContaining([1, 2, 3]));

        spyModuleStart.mockRestore();
        spyModule2Start.mockRestore();
        spyModule3Start.mockRestore();
...

mocking my function and pushing to an array and checking the array against the expected :/

[benjaminkay93]

you could do

const mock1 = jest.fn()
const mock2 = jest.fn()

expect(mock1.mock.invocationCallOrder).toBeLessThan(mock2.mock.invocationCallOrder)

[benjaminkay93]

The jest api changed from timestamp to invocationCallOrder so you dont have to mock out a timeout function inside the jest.fn() to get the innvocation order.

[nolazybits]

Thank you for the feedback
I'll give it a try on Monday :)

[jonohayon]

Having the same problem...
@mattphillips can you please publish the fixed version to npm?

[mattphillips]

Hey thanks for raising this, sorry about the delay in getting this published! It is now out in v0.8.0