[valid-expect-in-promise] Error is reported even though promise is awaited

[srmagura]

Minimal repro

This code

it("handles an error", async () => {
  const p = Promise.reject(new Error("test error")).then(undefined, (e) => {
    expect(e).toBeInstanceOf(Error);
    return "handled";
  });

  expect(await p).toBe("handled");
});

produces the error

This promise should either be returned or awaited to ensure the expects in it's chain are called  jest/valid-expect-in-promise

The promise is being awaited so the lint rule should not error.

Versions:

• "eslint": "7.32.0"
• "eslint-plugin-jest": "25.0.1"
• Node 14.17.6

[G-Rath]

🤦 I knew I'd forgot a valid situation like that.

Currently we're looking straight up for either a return or an await in the function body, but we should also check (somehow 🤔) if the promise is being awaited as a parameter to a function call that is within the test functions body

[github-actions]

🎉 This issue has been resolved in version 25.0.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀