[require-top-level-describe] false positive for describe.each?

[ljosberinn]

tests within describe.each throw the require-top-level-describe error - is this intended?

[SimenB]

Nah, that's a bug. Wanna send a PR?

[ljosberinn]

I've been trying but I'm afraid I don't know enough about the internals of eslint rules.

      MemberExpression(node) {
        if (
          node.parent?.type === 'CallExpression' &&
          isDescribe(node.parent) &&
          node.type === 'MemberExpression' &&
          node.property.type === 'Identifier' &&
          node.property.name === 'each'
        ) {
          numberOfDescribeBlocks++;

          return;
        }
      },
      'MemberExpression:exit'(node: TSESTree.MemberExpression) {
        if (
          node.parent?.type === 'CallExpression' &&
          isDescribe(node.parent) &&
          node.type === 'MemberExpression' &&
          node.property.type === 'Identifier' &&
          node.property.name === 'each'
        ) {
          numberOfDescribeBlocks--;

          return;
        }
      },

technically that works, as in, increments numberOfDescribeBlocks, but I'm fairly lost beyond that.

[github-actions]

🎉 This issue has been resolved in version 24.1.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀