feat(no-if): support switch statements
#515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah, I think I brought that up at some point |
Yeah I think you did actually - I'll add it to my todo list for next weekend :) |
|
#482, almost |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 12, 2020
# [23.6.0](v23.5.0...v23.6.0) (2020-01-12) ### Features * **no-if:** support `switch` statements ([#515](#515)) ([be4e49d](be4e49d))
|
🎉 This PR is included in version 23.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SimenB I think it might be worth refactoring this into
no-conditional-expectat some point 🤔Looking over
no-try-expect, I'm pretty sure they're doing almost the exact same thing - I'm going to look to reimplement one of these two rules so that they at least use the same style (one pushes booleans into an array, the other nodes, or something like that 🤷♂ )Fixes #505