Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add different setting for no-large-snapshots for inline vs external snaps #244

Closed
alexkrolick opened this issue Apr 17, 2019 · 6 comments · Fixed by #524
Closed

Add different setting for no-large-snapshots for inline vs external snaps #244

alexkrolick opened this issue Apr 17, 2019 · 6 comments · Fixed by #524
Labels
enhancement good first issue help wanted released

Comments

@alexkrolick
Copy link

It would be cool to be able to specify the max length of inline snapshots separately from snapshots in files.

Main use case is setting inlineSnapshots to be something like 15 lines max, but a larger number like 50 for regular snapshots.
@SimenB
Copy link
Member

SimenB commented Apr 17, 2019

Yeah, great idea! Wanna send a PR?

@alexkrolick
Copy link
Author

Yes, I'll send one

@alexkrolick alexkrolick mentioned this issue Jul 31, 2019
Closed
@alexkrolick
Copy link
Author

alexkrolick commented Jul 31, 2019 •
edited
Loading

(still planning on doing this unless someone else claims it)

@alexkrolick alexkrolick mentioned this issue Jul 31, 2019
Open
@leonardovillela
Copy link
Contributor

Can I take this issue?

@SimenB
Copy link
Member

SimenB commented Jan 20, 2020

Yeah, go for it 🙂

@leonardovillela leonardovillela mentioned this issue Jan 23, 2020
Merged
@github-actions
Copy link

🎉 This issue has been resolved in version 23.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted released
Projects
None yet
Milestone
No milestone
3 participants
@SimenB @alexkrolick @leonardovillela