Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(no-focused-tests): make reporting location consistent #1443

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Sep 29, 2023

Currently for .only we report on that identifier itself, whereas for fit and fdescribe we report on the whole call expression - while arguably reporting on the call expression is more accurate since we're about about the test as a whole being skipped, some editors handle reporting on call expressions poorly.

@G-Rath G-Rath merged commit a871775 into main Sep 29, 2023
32 checks passed
@G-Rath G-Rath deleted the adjust-no-focused-tests branch September 29, 2023 21:15
github-actions bot pushed a commit that referenced this pull request Sep 29, 2023
## [27.4.1](v27.4.0...v27.4.1) (2023-09-29)

### Bug Fixes

* **no-focused-tests:** make reporting location consistent ([#1443](#1443)) ([a871775](a871775))
@github-actions
Copy link

🎉 This PR is included in version 27.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant