fix: produce valid code when when fixing properties accessed with square brackets #1131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very minor (I really don't think anyone is accessing properties this way) but it's technically a bug - I realised afterwards that the alternative is to do:
which ensures the whole accessor is removed correctly making it safe to not use quotes - I'm not fussed which fix we actually do, but felt this helper was slightly better by way of being more readable 🤷
We could be using it in
no-deprecated-functions
too except that technically isn't using a node of typeAccessorNode
so have left it as-is for now since it technically should be refactored anyway to use the new jest function parser.