feat: create prefer-snapshot-hint rule
#1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
create-prefer-snapshot-hint-rule
branch
3 times, most recently
from
ebb1e39 to
41c7c39
Compare
G-Rath
force-pushed
the
create-prefer-snapshot-hint-rule
branch
from
41c7c39 to
2533443
Compare
G-Rath
force-pushed
the
create-prefer-snapshot-hint-rule
branch
from
ebc3e00 to
94d72dc
Compare
G-Rath
force-pushed
the
create-prefer-snapshot-hint-rule
branch
from
94d72dc to
46e9497
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Feb 6, 2022
# [26.1.0](v26.0.0...v26.1.0) (2022-02-06) ### Features * create `no-conditional-in-test` rule ([#1027](#1027)) ([d551850](d551850)) * create `prefer-snapshot-hint` rule ([#1012](#1012)) ([d854723](d854723)) * deprecate `no-if` in favor of `no-conditional-in-test` ([#1049](#1049)) ([35f32cc](35f32cc))
|
🎉 This PR is included in version 26.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hintinstead ofnameas that's what the argument is called in the docs - however the docs do refer to it in a few places as "snapshot name" and it is used as part of the name. @SimenB imo it would be good to be consistent, so would be good if you could weigh in on if you'd preferhintornameand I can do the legwork of making a PR tojestupdating the docs and argument(s) to matchneveroption because I really don't think that is something people should be doing since there's no gain in not having a hint.multias the default because I think that is reasonable to assume the test title has enough context for one external snapshot matcher, but as soon as you have multiple in a single test you can't tell what each snapshot actually is from the snap along without a hint.Resolves #103