You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The root cause is that we don't close the filter prompt before opening the new menu. There's a whole class of bugs that is caused by this; the crash is only one manifestation.
Another example:
start in the files panel
hit / to start searching
hit ctrl-s to open the Filtering menu
the menu is positioned in the upper-left corner rather than in the middle of the screen
dismiss the menu by hitting escape
search prompt is still open, but you can't see it. You need to hit esc again to cancel so that lazygit behaves normally again.
Expected behavior Should activate the "Custom patch option" as if no search were initiated
This is debatable; you could also say "Should do nothing while the search prompt is open", so you first need to hit either enter or escape to dismiss the prompt before you can hit ctrl-p.
I also tried to fix it the other way (by cancelling the search prompt when opening a menu), but it was harder to get all cases to work correctly that way. For example, I'm not sure we want to also cancel a filter prompt when a confirmation popup is opened (I don't know, maybe we do?).
Describe the bug
Bug when searching and then pressing
Ctrl-p
in commit menu.To Reproduce
Steps to reproduce the behavior:
Expected behavior
Should activate the "Custom patch option" as if no search were initiated
Version info:
lazygit --version
:commit=71ad3fac63a3ef3326021837b49e9497d332818b, build date=2024-07-13T10:24:19Z, build source=binaryRelease, version=0.43.1, os=linux, arch=amd64, git version=2.34.1
git --version
: git version 2.34.1Additional context
Doesn't crash if no search is initiated.
Note: please try updating to the latest version or manually building the latest
master
to see if the issue still occurs.The text was updated successfully, but these errors were encountered: