Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS review #128

Closed
cole-brokamp opened this issue Aug 16, 2021 · 4 comments
Closed

JOSS review #128

cole-brokamp opened this issue Aug 16, 2021 · 4 comments

Comments

@cole-brokamp
Copy link

Hello! I am listing two smaller review points here for my JOSS review (openjournals/joss-reviews#3544)

  • consider combining LICENSE.md and LICENSE into one file to prevent confusion
  • please add a section title called "Statement of Need"; I believe this is sufficiently described, but just need to organize it into a section with this specific title
@jessecambon
Copy link
Owner

Hi @cole-brokamp, thanks. To your second bullet, the middle section "Challenges in Geocoding" is the statement of need. I can just change that section title to be "Statement of Need" if that would work for you.

To your first bullet, while I agree in principle, the CRAN regulations prevent this:

Complete and ship as file LICENSE the following 2
lines (only)

YEAR:
COPYRIGHT HOLDER:

and specify as

License: MIT + file LICENSE
-https://cran.r-project.org/web/licenses/MIT

You can see a more extended discussion on this topic here: tidyverse/tidyr#262.

@dieghernan
Copy link
Contributor

Very common problem on JOSS reviews due to CRAN policy, see also kadyb/rgugik#61

@cole-brokamp
Copy link
Author

Thanks for the information. I don't think there is anything that can be done about the LICENSE files. I think that renaming the middle section as Statement of Need would work to satisfy JOSS requirements.

@jessecambon
Copy link
Owner

Sounds good, I just made that change:

a111b67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants