Source Map Support #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ``` | ||
|
|
||
| Docs below should explain the methods executed in the example above. | ||
| It's also important to note that accord return an object rather than a string from each of these methods. You can access the compiled result on the `result` property of this object. If the adapter supports source maps, the source map will also be on this object if you have passed in the correct options. Docs below should explain the methods executed in the example above. |
There was a problem hiding this comment.
"note that accord return_s_ an object"
|
still needs to be able to accept an object ( |
|
Oh, also - this requires a major version bump. |
added 6 commits
December 17, 2014 15:58
|
Changes Unknown when pulling 720816c on 0.13.0 into * on master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a massively breaking change, but also includes full support for sourcemaps from any adapter that supports them. This means most css and js languages and hardly any of the html ones. The breaking change is that rather than returning a compiled string, you now get back an object which always contains a
resultkey with the compiled result, and sometimes might include asourcemapkey as well.The good news is that if, down the line, there is any other information that needs to be included (coffeescript already returns 2 different types of sourcemaps), the object is flexible enough to accommodate.
Tests are passing, the fail is a travis/libsass bug.