Isn't it okay to remove simple_webhook_url and simple_proxy?

[nsano-rururu]

As far as I read the message in the warning log, I thought that the code related to simple_webhook_url and simple_proxy could be deleted.

            elastalert_logger.warning(
                '"simple" alerter has been renamed "post" and comptability may be removed in a future release.')

https://github.com/jertel/elastalert2/blob/master/elastalert/schema.yaml#L287

  ### Simple
  simple_webhook_url: *arrayOfString
  simple_proxy: {type: string}

L554 - 564
https://github.com/jertel/elastalert2/blob/master/elastalert/loaders.py#L554

    @staticmethod
    def adjust_deprecated_values(rule):
        # From rename of simple HTTP alerter
        if rule.get('type') == 'simple':
            rule['type'] = 'post'
            if 'simple_proxy' in rule:
                rule['http_post_proxy'] = rule['simple_proxy']
            if 'simple_webhook_url' in rule:
                rule['http_post_url'] = rule['simple_webhook_url']
            elastalert_logger.warning(
                '"simple" alerter has been renamed "post" and comptability may be removed in a future release.')

L296
https://github.com/jertel/elastalert2/blob/master/elastalert/loaders.py#L296

        self.adjust_deprecated_values(rule)

[jertel]

Yes, we could remove those schema defs and the code but it will be a breaking change for people that still use the old names, so we'll need to identify that in the changelog.

[nsano-rururu]

Yes, we could remove those schema defs and the code but it will be a breaking change for people that still use the old names, so we'll need to identify that in the changelog.

When issuing a pull request, it should be described in the Breaking changes of the change log.

[nsano-rururu]

I submitted a pull request
#793