Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotation and Stretch problems ( iOs® and Android® ) #242

Closed
AndreaMonzini opened this issue Nov 7, 2017 · 11 comments
Closed

Rotation and Stretch problems ( iOs® and Android® ) #242

AndreaMonzini opened this issue Nov 7, 2017 · 11 comments

Comments

@AndreaMonzini
Copy link

AndreaMonzini commented Nov 7, 2017

Hello,
i did some test and i see 3D Rotation and 3D Stretch problems on iOs® and Android® devices and it seems they related also to the orientation of the Devices in the space beside the portrait mode:

Tested on iPad® Air, iPhone® ( iOs® 11 ) and Android® Phone ( Firefox® 56 , Chrome® 61 )

  • in portrait mode, if the iPAd®, iPhone® or Android® Phone are Vertical ( parallel to the wall) and the marker is on the wall: wrong rotation of the 3D content and 3D is also stretched.

  • in portrait mode, if the iPAd®, iPhone® or Android® Phone are Horizontal ( Parallel to the table) and the marker is on the table: correct rotation of the 3D content but 3D is stretched.

  • In landscape mode if the iPAd®, iPhone® or Android® Phone are Vertical ( parallel to the wall) and the marker is on the table: works well

  • In landscape mode if the iPAd®,iPhone® or Android® Phone are Horizontal ( Parallel to the table) and the marker is on the table: works well

Conclusion:

Solutions:
#212 #246

@javismiles
Copy link

That's exactly right, I have been testing in both laptop PC and android/iOS and yes the stretching happens on mobile devices

@Adolar13
Copy link

Hey @javismiles I tried the changes from @pikilipita in #212. Works for me.
I attached the aframe-ar.js with the changes, while it's not merged in the main branch.
aframe-ar.zip

@javismiles
Copy link

@Adolar13 thank you very much, really appreciated, i wonder if this will fix all the distorsion issues i had found on android, thank you again

@AndreaMonzini
Copy link
Author

AndreaMonzini commented Nov 15, 2017

Just tested it and the problems seem solved on Android ®! i will test it as soon as possibile on iOs®
Only the overlay elements position seems shifted.
Thank you @pikilipita and @Adolar13 !

@javismiles
Copy link

thank you again , this fix seems to work well, can you guys help with another issue related to clicks?

my marker when detected activates and shows a video (I use a-frame with ar.js, so aframe-ar),
I want to detect a click on that video element, not on the whole screen, for some reason yes I can detect a click but its detected in the entire whole screen, instead of just
in the video element itself, how can I make sure that it happens on the video element itself?

Also I am using onclick events now because this used to work:

AFRAME.registerComponent('javi1', {
init: function () {
var el = this.el;
el.addEventListener('click', function (evt) {... etc

but now its not working anymore for some reason,

what's your recommended way to detect a click on the specific video element?

btw, in console Im receiving these 2 warnings, do they have any relation to the issues with clicks?
"THREE.WebGLRenderer 87
pictoar1js.min.js:3 extras:primitives:warn Mapping keys should be specified in lower case. The mapping key minConfidence may not be recognized
pictoar1js.min.js:3 extras:primitives:warn Mapping keys should be specified in lower case. The mapping key hit-testing-renderDebug may not be recognized "

thanks a lot

@AndreaMonzini
Copy link
Author

hello @javismiles I'm trying to test video with ios® using webkit-playsinline and playsinline but the video does not start, do you have a working project example ?
Thank you.

@javismiles
Copy link

javismiles commented Nov 16, 2017 via email

@AndreaMonzini
Copy link
Author

@javismiles thank you ! tomorrow i will try video in AR.js again ;)

@lslzl3000
Copy link

Also working on the roataion and strech problem~
Is there a plan to fix this issue or merge into main branch?

@AndreaMonzini
Copy link
Author

AndreaMonzini commented Dec 18, 2017

Waiting for main branch, we have these solutions:

#212 #246

@nicolocarpignoli
Copy link
Collaborator

closing as MR were merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants