Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seek() should also reset all controllers #1

Open
jeroenwalter opened this issue May 24, 2020 · 0 comments
Open

Seek() should also reset all controllers #1

jeroenwalter opened this issue May 24, 2020 · 0 comments

Comments

@jeroenwalter
Copy link
Owner

Seek() is implemented as a replay of all the midi messages from the start, while muting any note on/off requests. This allows for control changes and tempo changes to be done correctly.
It also mutes all channels before the replay.
However, it doesn't reset all controllers before the replay, so controllers like modulation and pitch will still have their last value.

When the player starts a new song, all controllers are reset. As the Seek operation basically is the same as starting a new song, it should also reset all controllers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant