Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 6 support #29

Open
oixan opened this issue Sep 21, 2019 · 6 comments
Open

Laravel 6 support #29

oixan opened this issue Sep 21, 2019 · 6 comments

Comments

@oixan
Copy link

oixan commented Sep 21, 2019

Any chance that this package can be updated for Laravel 6?

@denjaland
Copy link

Not sure if this package is still being maintained? @jeroennoten could you shed some light on this?
Thanks very much!

@jeroennoten
Copy link
Owner

Hi, unfortunately I don’t have the time to maintain this package.

@oixan
Copy link
Author

oixan commented Sep 27, 2019

Sad news, I hope someone can work on this package in the future!

Just 1 thing. Changing on composer.json file "illuminate/support": "~5.0.14|~5.1", to
"illuminate/support": "~5.0.14|~5.1|^6.0" will make the package work with laravel 6?

@denjaland
Copy link

I took a copy of the middleware and put in our codebase directly. You can change compoer dependency, and there is one array_ or str_ function ( don’t recall by heart) that needs updating...

@keliix06
Copy link

keliix06 commented Nov 6, 2019

PrerenderMiddleware.php has 2 str_ functions. Line 154 change str_contains to Str::contains and line 248 change str_is to Str::is.

@bilias23
Copy link

I researched the forks a bit, I think these two are complete:

I chose the latter, but forked it so I can tag it with a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants