Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore matchers run against absolute paths #75

Open
conartist6 opened this issue Aug 12, 2019 · 3 comments
Open

Ignore matchers run against absolute paths #75

conartist6 opened this issue Aug 12, 2019 · 3 comments

Comments

@conartist6
Copy link

This makes it impossible to, make an ignore entry like path/in/my/project.

@conartist6
Copy link
Author

Also the code goes to the trouble of creating a reusable matcher, but it only ever uses that matcher once. Creation of the matcher can and should be pushed up a line, out of (path, stats) callback for perf.

@conartist6
Copy link
Author

And finally, if you pass a function as the ignore expression, a promise is not returned from the expression, leading to crashes. I certainly expected to be able to pass an ignore function, instead of having to pass an array of ignore functions.

@conartist6
Copy link
Author

conartist6 commented Aug 12, 2019

I'll make a PR if I get around to it. For now I'm able to work around these issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant