checkstyle suggestions

jeremylong · May 19, 2018 · 654e772 · 654e772
1 parent 6d05b45
commit 654e772
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/core/src/main/java/org/owasp/dependencycheck/analyzer/JarAnalyzer.java b/core/src/main/java/org/owasp/dependencycheck/analyzer/JarAnalyzer.java
@@ -723,7 +723,6 @@ protected boolean parseManifest(Dependency dependency, List<ClassNameInformation
                     value = value.substring(15);
                 }
                 if (IGNORE_VALUES.contains(value)) {
-                    //noinspection UnnecessaryContinue
                     continue;
                 } else if (key.equalsIgnoreCase(Attributes.Name.IMPLEMENTATION_TITLE.toString())) {
                     foundSomething = true;

diff --git a/maven/src/main/java/org/owasp/dependencycheck/maven/BaseDependencyCheckMojo.java b/maven/src/main/java/org/owasp/dependencycheck/maven/BaseDependencyCheckMojo.java
@@ -586,7 +586,7 @@ public abstract class BaseDependencyCheckMojo extends AbstractMojo implements Ma
     @Override
     public void execute() throws MojoExecutionException, MojoFailureException {
         generatingSite = false;
-        boolean shouldSkip = Boolean.parseBoolean(System.getProperty("dependency-check.skip", Boolean.toString(skip)));
+        final boolean shouldSkip = Boolean.parseBoolean(System.getProperty("dependency-check.skip", Boolean.toString(skip)));
         if (shouldSkip) {
             getLog().info("Skipping " + getName(Locale.US));
         } else {
@@ -662,7 +662,7 @@ protected boolean isFailOnError() {
      * @throws MavenReportException if a maven report exception occurs
      */
     public void generate(Sink sink, Locale locale) throws MavenReportException {
-        boolean shouldSkip = Boolean.parseBoolean(System.getProperty("dependency-check.skip", Boolean.toString(skip)));
+        final boolean shouldSkip = Boolean.parseBoolean(System.getProperty("dependency-check.skip", Boolean.toString(skip)));
         if (shouldSkip) {
             getLog().info("Skipping report generation " + getName(Locale.US));
             return;

diff --git a/utils/src/main/java/org/owasp/dependencycheck/utils/SSLSocketFactoryEx.java b/utils/src/main/java/org/owasp/dependencycheck/utils/SSLSocketFactoryEx.java
@@ -46,7 +46,7 @@ public class SSLSocketFactoryEx extends SSLSocketFactory {
      * The configured settings.
      */
     private final Settings settings;
-    
+
     /**
      * Simple boolean flag to prevent logging the protocols repeatedly.
      */

diff --git a/utils/src/main/java/org/owasp/dependencycheck/utils/URLConnectionFactory.java b/utils/src/main/java/org/owasp/dependencycheck/utils/URLConnectionFactory.java
@@ -123,7 +123,7 @@ public PasswordAuthentication getPasswordAuthentication() {
             }
             throw new URLConnectionFailureException("Error getting connection.", ex);
         }
-        //conn.setRequestProperty("user-agent", 
+        //conn.setRequestProperty("user-agent",
         //  "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36");
         configureTLS(url, conn);
         return conn;
-Original file line number
+Diff line change
@@ Expand Up / @@ -46,7 +46,7 @@ public class SSLSocketFactoryEx extends SSLSocketFactory { @@
          * The configured settings.
          */
         private final Settings settings;
         /**
          * Simple boolean flag to prevent logging the protocols repeatedly.
          */
@@ Expand Down @@