Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using .end() without the flush parameter is deprecated and throws from v.3.0.0 on #12

Open
TiTi opened this issue Jul 6, 2016 · 2 comments
Assignees

Comments

@TiTi
Copy link

TiTi commented Jul 6, 2016

I'm using the dump() function in a nodejs script.
I got this warning on stderr:

node_redis: Using .end() without the flush parameter is deprecated and throws from v.3.0.0 on.
Please check the doku (https://github.com/NodeRedis/node_redis) and explictly use flush.

Also it seems each call to dump() does not close the connection.
I'm therefore ending up with a lot of connections opened after many calls to dump() :-(
To the point I'm exhausting redis connections:

events.js:141
throw er; // Unhandled 'error' event
^

Error: Redis connection to 171.40.11.07:6379 failed - connect ETIMEDOUT 171.40.11.07:6379
at Object.exports._errnoException (util.js:837:11)
at exports._exceptionWithHostPort (util.js:860:20)
at TCPConnectWrap.afterConnect as oncomplete

(this depends on your redis and linux tcp settings)

@jeremyfa jeremyfa self-assigned this Jul 6, 2016
@jeremyfa
Copy link
Owner

jeremyfa commented Jul 6, 2016

Indeed, these need to be fixed. Thanks for reporting!

@rodrigoaguilera
Copy link

PR sent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants