-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After pushing and tagging a release commit, build.yaml
should rebase the staging branch on top of main.
#266
Comments
As per linked comment:
I’m ok with using |
So I think we want to add another step after this one: python-package-template/.github/workflows/release.yaml Lines 57 to 60 in 25c486b
For example --- a/.github/workflows/release.yaml
+++ b/.github/workflows/release.yaml
@@ -68,6 +68,13 @@ jobs:
git push
git push --tags
+ - name: Rebase staging branch
+ continue-on-error: true
+ run: |
+ git checkout staging
+ git rebase main
+ git push
+
# When triggered by the version bump commit, build the package and publish the release artifacts.
build: We’ve already checked out all branches a few steps before: python-package-template/.github/workflows/release.yaml Lines 36 to 40 in 25c486b
That would only work, I think, if both |
Sounds fine with me. But before merging that we should investigate this whole branch protection vs automatic release through pull requests to make sure the histories would be in sync. At least we should understand why it's not working as we want in GitHub. |
There’s also this problem: what if the |
For details, see #259 (comment).
The text was updated successfully, but these errors were encountered: