Skip to content

Commit

Permalink
job-dsl-plugin compatible #13
Browse files Browse the repository at this point in the history
 * Using new Jenkins parent, 2.2.
 * Building for Jenkins 1.642.3.
 * Adding @DataBoundConstructor to ViolationConfig to make it compatible with job-dsl-plugin.
  • Loading branch information
tomasbjerre committed Aug 9, 2016
1 parent 33b92e4 commit 2ef1c84
Show file tree
Hide file tree
Showing 3 changed files with 35 additions and 1 deletion.
30 changes: 30 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,36 @@
Changelog of Violation Comments to Bitbucket Server Plugin.

## Unreleased
### GitHub [#13](https://github.com/jenkinsci/violation-comments-to-stash-plugin/issues/13) Problem with Pipeline Snippet Generation

**job-dsl-plugin compatible #13**

* Using new Jenkins parent, 2.2.
* Building for Jenkins 1.642.3.
* Adding @DataBoundConstructor to ViolationConfig to make it compatible with job-dsl-plugin.

[c70a514ce15f12e](https://github.com/jenkinsci/violation-comments-to-stash-plugin/commit/c70a514ce15f12e) Tomas Bjerre *2016-08-09 17:58:00*


## 1.18
### GitHub [#10](https://github.com/jenkinsci/violation-comments-to-stash-plugin/issues/10) Nothing seems to be happening, and no logging for debugging

**Credentials #10 #11**

* Also adding better logging.

[0b3f20a5ae650a4](https://github.com/jenkinsci/violation-comments-to-stash-plugin/commit/0b3f20a5ae650a4) Tomas Bjerre *2016-08-02 18:09:25*


### GitHub [#11](https://github.com/jenkinsci/violation-comments-to-stash-plugin/issues/11) Use Credentials

**Credentials #10 #11**

* Also adding better logging.

[0b3f20a5ae650a4](https://github.com/jenkinsci/violation-comments-to-stash-plugin/commit/0b3f20a5ae650a4) Tomas Bjerre *2016-08-02 18:09:25*


### No issue

**doc**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

import java.io.Serializable;

import org.kohsuke.stapler.DataBoundConstructor;

import se.bjurr.violations.lib.reports.Reporter;

public class ViolationConfig implements Serializable {
Expand All @@ -13,6 +15,7 @@ public ViolationConfig() {

}

@DataBoundConstructor
public ViolationConfig(Reporter reporter, String pattern) {
this.reporter = reporter;
this.pattern = pattern;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package org.jenkinsci.plugins.jvctb.perform;

import static com.google.common.base.Charsets.UTF_8;
import static com.google.common.base.Preconditions.checkNotNull;
import static com.google.common.base.Strings.emptyToNull;
import static com.google.common.base.Strings.isNullOrEmpty;
Expand Down Expand Up @@ -177,7 +178,7 @@ private static void logConfiguration(ViolationsToBitbucketServerConfig config, R
private static void setupFindBugsMessages() {
try {
String findbugsMessagesXml = CharStreams.toString(new InputStreamReader(JvctbPerformer.class
.getResourceAsStream("findbugs-messages.xml")));
.getResourceAsStream("findbugs-messages.xml"), UTF_8));
setFindbugsMessagesXml(findbugsMessagesXml);
} catch (IOException e) {
propagate(e);
Expand Down

0 comments on commit 2ef1c84

Please sign in to comment.