Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-50346] Cannot style build-monitor since 0.4 #107

Open
TobiX opened this issue Mar 22, 2018 · 1 comment
Open

[JENKINS-50346] Cannot style build-monitor since 0.4 #107

TobiX opened this issue Mar 22, 2018 · 1 comment

Comments

@TobiX
Copy link
Contributor

TobiX commented Mar 22, 2018

I added a "workaround" to not style build-monitor pages at all (cc68d1a82909f6e1fa1f9b4ec2a85b05d738383b) since all styles on GitHub are not aware of that plugin and therefore break its design.

Unfortunatly some users want to style the build-monitor and now aren't able anymore. This should therefore be user-configurable. Maybe tackle support for styling BlueOcean in a similar way (opt-in, see JENKINS-49081)


Originally reported by tgr, imported from: Cannot style build-monitor since 0.4
  • assignee: tgr
  • status: Open
  • priority: Minor
  • resolution: Unresolved
  • imported: 2022-10-30
@TobiX
Copy link
Contributor Author

TobiX commented Mar 23, 2018

taree7734:

I see a possible solutions here:

In jenkins-config add a list for ignored classes. These could be evaluated in SimpleThemeDecorator.java
Replace

if (o.getClass().getName().startsWith("com.smartcodeltd.jenkinsci.plugins.buildmonitor")) {
    return false;
}

with something like

for (String e : list) {
    if (o.getClass().getName().contains(e)) {
return false;
    }.
}

With that solution it would be fully user-configurable, which pages (/plugins) are excluded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant