Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove inline javascript #300

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Feb 2, 2024

remove the inline javascript from the redirect page and the index of the action.
use relative urls in the redirect instead of absoluturl which is considered dangerous (this probably fixes JENKINS-64825)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes

Types of changes

  • Maintenance

@mawinter69 mawinter69 requested a review from a team as a code owner February 2, 2024 23:32
remove the inline javascript from the redirect page and the index of the
action.
use relative urls in the redirect instead of absoluturl which is
considered dangerous (this probably fixes JENKINS-64825)
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Feb 6, 2024
@MarkEWaite MarkEWaite merged commit 27be5eb into jenkinsci:master Feb 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants