[JENKINS-19409] use idstrategy to match role assignments #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The matching users to roles was so far case sensitive. But as most security realms work case insensitive this means that permissions are not properly matched when someone logs in with capital letters but the role is assigned to the user with small letters. The plugin now falls back to the security realms idstrategy in case the user doesn't match case sensitive. For backward compatibility reasons, this feature can be switched off.
mawinter69
force-pushed
the
JENKINS-19409
branch
from
2f798b6 to
163ca53
Compare
mawinter69
force-pushed
the
JENKINS-19409
branch
from
163ca53 to
07d8313
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The matching of users to roles was so far case sensitive. But as most security realms work case insensitive this means that permissions are not properly matched when someone logs in with capital letters but the role is assigned to the user with small letters.
The plugin now falls back to the security realms idstrategy in case the user doesn't match case sensitive.
For backward compatibility reasons, this feature can be switched off via
com.michelin.cio.hudson.plugins.rolestrategy.RoleMap.FORCE_CASE_SENSITIVE. This can be set either as a startup java property, or via Jenkins script console or via a hook script.See JENKINS-19409 and others
Testing done
configured to use AD plugin
granted lower case username admin permissions
before: tried login with capital username -> failed with missing overall read
after: login with capital username -> user has admin permissions
Submitter checklist