Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom "abort" text #179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

giannello
Copy link

@giannello giannello commented Jul 11, 2024

Allow customizing the "Abort" text to better match the context, just like with "Proceed"

This supersedes #54

Solves JENKINS-66820

Testing done

Extended the existing automated tests

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@giannello giannello requested a review from a team as a code owner July 11, 2024 12:54
@giannello giannello force-pushed the feature/customizable-abort-text branch from 3622d18 to ea2dd55 Compare July 11, 2024 12:55
@@ -32,6 +32,9 @@ THE SOFTWARE.
<f:entry field="id" title="${%Custom ID}">
<f:textbox/>
</f:entry>
<f:entry field="cancel" title="${%Cancel Button Caption}">
<f:textbox/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No default, yet getCancel is setting a default. I think this means that snippet generator will suggest a cancel parameter even if you did not touch this option, which is undesirable: parameters proposed for the Groovy form of the step should include solely those fields which you actually edited from the default. Docs

Copy link
Author

@giannello giannello Jul 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't seem to be the case. I have deployed my custom HPI to our jenkins instance (Version 2.452.3 with all plugins up-to-date), and the behaviour is as following:
default when selecting the "input" sample step and clicking "Generate pipeline script"
image
after expanding "advanced" and clicking "generate pipeline script"
image
Adding a custom "cancel" caption
image
Adding a custom "OK" caption
image
Adding both
image

@giannello giannello requested a review from jglick July 12, 2024 07:48
@jglick jglick requested review from a team and removed request for jglick July 15, 2024 18:13
@giannello giannello force-pushed the feature/customizable-abort-text branch from ea2dd55 to 0afbcb5 Compare July 16, 2024 09:28
@giannello
Copy link
Author

@strangelookingnerd @MarkEWaite @dwnusbaum sorry for the broad ping. This PR is 2 months old, can anybody give it a review?

@giannello
Copy link
Author

@strangelookingnerd @MarkEWaite @jglick pinging again: is there anything missing for this to be merged/released? I would really love to get this done :)

@jglick
Copy link
Member

jglick commented Dec 3, 2024

I can ask around if there are any plugin maintainers watching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants