-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom "abort" text #179
base: master
Are you sure you want to change the base?
Allow custom "abort" text #179
Conversation
3622d18
to
ea2dd55
Compare
@@ -32,6 +32,9 @@ THE SOFTWARE. | |||
<f:entry field="id" title="${%Custom ID}"> | |||
<f:textbox/> | |||
</f:entry> | |||
<f:entry field="cancel" title="${%Cancel Button Caption}"> | |||
<f:textbox/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No default
, yet getCancel
is setting a default. I think this means that snippet generator will suggest a cancel
parameter even if you did not touch this option, which is undesirable: parameters proposed for the Groovy form of the step should include solely those fields which you actually edited from the default. Docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That doesn't seem to be the case. I have deployed my custom HPI to our jenkins instance (Version 2.452.3 with all plugins up-to-date), and the behaviour is as following:
default when selecting the "input" sample step and clicking "Generate pipeline script"
after expanding "advanced" and clicking "generate pipeline script"
Adding a custom "cancel" caption
Adding a custom "OK" caption
Adding both
ea2dd55
to
0afbcb5
Compare
@strangelookingnerd @MarkEWaite @dwnusbaum sorry for the broad ping. This PR is 2 months old, can anybody give it a review? |
@strangelookingnerd @MarkEWaite @jglick pinging again: is there anything missing for this to be merged/released? I would really love to get this done :) |
I can ask around if there are any plugin maintainers watching. |
Allow customizing the "Abort" text to better match the context, just like with "Proceed"
This supersedes #54
Solves JENKINS-66820
Testing done
Extended the existing automated tests
Submitter checklist