Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConsoleView: Make steps (and stages) indicate their status #29

Closed
timbrown5 opened this issue Jul 26, 2021 · 1 comment · Fixed by #131
Closed

ConsoleView: Make steps (and stages) indicate their status #29

timbrown5 opened this issue Jul 26, 2021 · 1 comment · Fixed by #131
Assignees
Labels
feature A PR that adds a feature - used by Release Drafter

Comments

@timbrown5
Copy link
Contributor

Currently, all the tree items in the ConsoleVIew look the same. It would be nice for them to be redered differently depending on their status (e.g. including a status Icon, or marking the left hand border green/yellow/red depending on status).

The status should already be available as state from:
https://github.com/jenkinsci/pipeline-graph-view-plugin/blob/main/src/main/frontend/pipeline-graph-view/pipeline-graph/main/PipelineGraphModel.tsx#L46 (stage)
and
https://github.com/jenkinsci/pipeline-graph-view-plugin/blob/main/src/main/frontend/pipeline-console-view/pipeline-console/main/DataTreeView.tsx#L26 (step)

I hope this will be as simple as adding a class for each state in the CSS and setting that class when the item is added to the DataTreeVIew.

@timja timja added the feature A PR that adds a feature - used by Release Drafter label Jul 26, 2021
@timja timja self-assigned this Sep 13, 2022
@timja
Copy link
Member

timja commented Sep 24, 2022

Will be fixed by #131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A PR that adds a feature - used by Release Drafter
Projects
None yet
2 participants