[JENKINS-32924] Add LogRotator to Workflow Multibranch

[meip]

Jira ticket: https://issues.jenkins-ci.org/browse/JENKINS-32924

Add a LogRotator to Workflow Multibranch Jobs to rotate build artifacts.

[jenkinsadmin]

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

[daspilker]

Sorry for the late feedback. I'm running Jenkins 1.625 with Pipeline Multibranch 1.14 and Branch API 1.7. I can't find a setting for the strategy in the UI. What do I need to do to test this? Or has this become obsolete?

[daspilker]

I made the BranchSourcesContext extensible (see #846) so that it will work with the Automatically Generated DSL. The embedded API viewer shows several options for strategy, but the UI does not show any strategy.

[meip]

I think this property is gone from the "root" config and should better be configured via Pipeline script. The Pipeline Multibranch is a bit messed up with properties inherited to branches. See discussion here:
https://issues.jenkins-ci.org/browse/JENKINS-30519
https://issues.jenkins-ci.org/browse/JENKINS-34005

An example to do it within Jenkinsfile is here: https://github.com/jenkinsci/workflow-multibranch-plugin/blob/master/src/test/java/org/jenkinsci/plugins/workflow/multibranch/JobPropertyStepTest.java

As you can see there should also be an option to set it with the Config File Provider Plugin.

Considering these two options, and your remarks that it is no more possible to configure logRotation for Multibranch via Gui, I don't know if we should purge this PR?

[daspilker]

Ah, thanks for the pointers. Since logRotator is supposed to be configured in Jenkinsfile and not on the multi-branch job, I'm closing this PR.