Fix: Don't destroy credentials when re-creating organization folders #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it's a `Folder` object we're referencing, so this makes it a bit clearer.
jamietanna
force-pushed
the
defect/org-folder-secrets
branch
from
c07be44
to
96562ba
Compare
Similar to 8d8ea63, we should be able to support organization folders not losing their credentials. This requires we bump our dependency of `credentials` to pick up the `branch-api` dependency. We need to handle the various bits of metadata available in the `OrganizationFolder`s, so our tests are slightly more complex than we usually have. Co-authored-by: Jean-François Roche <[email protected]> Closes JENKINS-44681.
jamietanna
force-pushed
the
defect/org-folder-secrets
branch
from
7a383b6
to
4b940e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to 8d8ea63, we should be able
to support organization folders not losing their credentials.
This requires we bump our dependency of
credentialsto pick up thebranch-apidependency.We need to handle the various bits of metadata available in the
OrganizationFolders, so our tests are slightly more complex than weusually have.
Co-authored-by: Jean-François Roche [email protected]
Closes JENKINS-44681.
Picks up from #1248.