Add classes and ID's for common elements #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should aid theme developers in developing plugins for Jenkins by adding
CSS classes and ID's to the dom. Developers can then use these to more
specifically target elements that they want.
For example, the "Console Output" was a raw <pre> tag embedded in a <table>.
Styling it required CSS like so:
#main-panel > pre {
Sadly this will apply to any <pre> elements nested directly under the
"#main-panel" ID; there's no way to get more specific to the console output.
With this change you can style the console output by writing:
.console-output {
Which is much more direct (and more efficient for browsers to render).
A similar treatment is applied to a number of elements in the jenkins UI.
|
core » jenkins_main_trunk #1259 SUCCESS |
|
Excited to see this happen... |
|
BUMP. I am very excited for this too. |
|
core » jenkins_main_trunk #1278 SUCCESS |
|
+1 |
|
👍 Looks good to me |
olivergondza
added a commit
that referenced
this pull request
Oct 14, 2013
Add classes and ID's for common elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should aid theme developers in developing plugins for Jenkins by adding
CSS classes and ID's to the dom. Developers can then use these to more
specifically target elements that they want.
For example, the "Console Output" was a raw
<pre>tag embedded in a<table>.Styling it required CSS like so:
Sadly this will apply to any
<pre>elements nested directly under the"#main-panel" ID; there's no way to get more specific to the console output.
With this change you can style the console output by writing:
Which is much more direct (and more efficient for browsers to render).
A similar treatment is applied to a number of elements in the jenkins UI.