Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with spaces in paths and job names #144

Closed
shivkaushal opened this issue Apr 5, 2016 · 1 comment
Closed

Problems with spaces in paths and job names #144

shivkaushal opened this issue Apr 5, 2016 · 1 comment

Comments

@shivkaushal
Copy link

I tried to use this library for something I was getting going at work and it fell over at certain parts because I was running against a Jenkins instance that spaces in the path to jobs (using the folder plugin, I think) as well as the job names.

I was able to work around it by making the following change in the private URI api(String path) method in JenkinsHttpClient.java:

<         return uri.resolve("/").resolve(path);

---
>         return uri.resolve("/").resolve(path.replace(" ","%20"));

This was a pretty quick, hacky fix that resolved my issue.... Would this be reasonable to submit as a pull request or would you want to approach it in a different (i.e. better) way?

@khmarbaise khmarbaise added this to the Release 0.3.4 milestone Apr 6, 2016
@khmarbaise
Copy link
Member

A pull request would be great...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants