-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DefaultArtifactVersion.majorVersion
0 for JEP-229 versions
#29
Comments
jenkinsci/mailer-plugin#149 (comment) says this applies only to Maven 2.x and not 3.x? |
At a minimum https://github.com/jenkinsci/lib-version-number/blob/f1ed0e92de5cf083e710b4d5a4d2c214635d4674/src/test/java/hudson/util/VersionNumberTest.java#L138 is inadequate and should be extended to cover comparisons between traditional and JEP-229 formats. |
https://github.com/jtnord/maven-version-compare-tool shows a different behaviour when using the the library from the Maven 3 series agrees with |
org.apache.maven.artifact.versioning.ComparableVersion.class.protectionDomain.codeSource.location giving me 3.8.2 in a reasonable current installation? I have not checked behavior of |
Still true in Maven 3 as per https://github.com/apache/maven/blob/18725ec1e05e01b06557830ae10e83bdb933ab1a/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java#L200-L208. What this means or where it is used remains TBD. |
Not called at all in Maven core AFAICT. https://github.com/apache/maven/blob/18725ec1e05e01b06557830ae10e83bdb933ab1a/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java#L77 means that |
/**
* @author Stephen Connolly
*/ LOL |
Having a hard time following the logic in Not sure how much any of this matters; I do not think we routinely use Switching from |
DefaultArtifactVersion.majorVersion
evaluating to 0 for JEP-229 versions?DefaultArtifactVersion.majorVersion
evaluating to 0 for JEP-229 versions
DefaultArtifactVersion.majorVersion
evaluating to 0 for JEP-229 versionsDefaultArtifactVersion.majorVersion
0 for JEP-229 versions
@jtnord reports #19 (comment).
maven-versions-plugin
claimed to be?.
to-
indeed placates Maven, without breaking comparisons for the Jenkins parser or Dependabot, and if so:.
.The text was updated successfully, but these errors were encountered: