Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generic ephemeral storage #982

Closed
justusbunsi opened this issue Jan 17, 2024 · 1 comment · Fixed by #983
Closed

Add support for generic ephemeral storage #982

justusbunsi opened this issue Jan 17, 2024 · 1 comment · Fixed by #983
Labels
enhancement New feature or request

Comments

@justusbunsi
Copy link
Member

Is your feature request related to a problem? Please describe

jenkinsci/kubernetes-plugin#1489 introduces the possibility to use ephemeral storage volumes in the Build pod specification. According to

{{- if (eq .Values.agent.workspaceVolume.type "DynamicPVC") }}
dynamicPVC:
{{- else if (eq .Values.agent.workspaceVolume.type "EmptyDir") }}
emptyDirWorkspaceVolume:
{{- else if (eq .Values.agent.workspaceVolume.type "HostPath") }}
hostPathWorkspaceVolume:
{{- else if (eq .Values.agent.workspaceVolume.type "Nfs") }}
nfsWorkspaceVolume:
{{- else if (eq .Values.agent.workspaceVolume.type "PVC") }}
persistentVolumeClaimWorkspaceVolume:
{{- else }}
{{ .Values.agent.workspaceVolume.type }}:
{{- end }}
the Helm Chart currently not support that new type genericEphemeralVolume.

Describe the solution you'd like

I happily provide a PR to add that support. What I would need to know is whether I should also bump the kubernetes-plugin in such PR to the supporting version or if I should split it into different PRs? It looks like there is no automatism right now to update the listed plugins.

Describe alternatives you've considered

No response

Additional context

No response

@justusbunsi justusbunsi added the enhancement New feature or request label Jan 17, 2024
@timja
Copy link
Member

timja commented Jan 17, 2024

I happily provide a PR to add that support. What I would need to know is whether I should also bump the kubernetes-plugin in such PR to the supporting version or if I should split it into different PRs? It looks like there is no automatism right now to update the listed plugins.

Combined PR is fine, there's discussion in this pull request about automating the update of the plugin: #979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants