diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
new file mode 100644
index 0000000..654cb6c
--- /dev/null
+++ b/.github/CODEOWNERS
@@ -0,0 +1 @@
+* @jenkinsci/groovy-events-listener-plugin-developers
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
new file mode 100644
index 0000000..0648c1e
--- /dev/null
+++ b/.github/dependabot.yml
@@ -0,0 +1,12 @@
+# https://docs.github.com/code-security/dependabot/dependabot-version-updates/configuring-dependabot-version-updates
+---
+version: 2
+updates:
+ - package-ecosystem: "maven"
+ directory: "/"
+ schedule:
+ interval: "weekly"
+ - package-ecosystem: "github-actions"
+ directory: "/"
+ schedule:
+ interval: "weekly"
diff --git a/.github/release-drafter.yml b/.github/release-drafter.yml
index dadb71f..550da01 100644
--- a/.github/release-drafter.yml
+++ b/.github/release-drafter.yml
@@ -1,3 +1,4 @@
+# https://github.com/jenkinsci/.github/blob/master/.github/release-drafter.adoc
+---
_extends: .github
-tag-template: $NEXT_MINOR_VERSION
-version-template: $MAJOR.$MINOR
+tag-template: groovy-events-listener-plugin-$NEXT_MINOR_VERSION
diff --git a/.github/workflows/jenkins-security-scan.yml b/.github/workflows/jenkins-security-scan.yml
new file mode 100644
index 0000000..9d17244
--- /dev/null
+++ b/.github/workflows/jenkins-security-scan.yml
@@ -0,0 +1,23 @@
+# More information about the Jenkins security scan can be found at the developer docs: https://www.jenkins.io/redirect/jenkins-security-scan/
+---
+name: Jenkins Security Scan
+on:
+ push:
+ branches:
+ - "master"
+ - "main"
+ pull_request:
+ types: [opened, synchronize, reopened]
+ workflow_dispatch:
+
+permissions:
+ security-events: write
+ contents: read
+ actions: read
+
+jobs:
+ security-scan:
+ uses: jenkins-infra/jenkins-security-scan/.github/workflows/jenkins-security-scan.yaml@v2
+ with:
+ java-cache: 'maven' # Optionally enable use of a build dependency cache. Specify 'maven' or 'gradle' as appropriate.
+ java-version: 11 # What version of Java to set up for the build.
diff --git a/.github/workflows/release-drafter.yml b/.github/workflows/release-drafter.yml
new file mode 100644
index 0000000..a1a5a1a
--- /dev/null
+++ b/.github/workflows/release-drafter.yml
@@ -0,0 +1,17 @@
+# Automates creation of Release Drafts using Release Drafter
+# More Info: https://github.com/jenkinsci/.github/blob/master/.github/release-drafter.adoc
+---
+on:
+ push:
+ branches:
+ - master
+ - main
+
+jobs:
+ update_release_draft:
+ runs-on: ubuntu-latest
+ steps:
+ # Drafts your next Release notes as Pull Requests are merged into the default branch
+ - uses: release-drafter/release-drafter@v5
+ env:
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
diff --git a/.mvn/extensions.xml b/.mvn/extensions.xml
new file mode 100644
index 0000000..1f36364
--- /dev/null
+++ b/.mvn/extensions.xml
@@ -0,0 +1,7 @@
+
+
+ io.jenkins.tools.incrementals
+ git-changelist-maven-extension
+ 1.7
+
+
diff --git a/.mvn/maven.config b/.mvn/maven.config
new file mode 100644
index 0000000..2a0299c
--- /dev/null
+++ b/.mvn/maven.config
@@ -0,0 +1,2 @@
+-Pconsume-incrementals
+-Pmight-produce-incrementals
diff --git a/Jenkinsfile b/Jenkinsfile
index 72be649..ccddb0d 100644
--- a/Jenkinsfile
+++ b/Jenkinsfile
@@ -1,2 +1,4 @@
-
-buildPluginWithGradle(jdkVersions: ['11'])
+buildPlugin(useContainerAgent: true, configurations: [
+ [platform: 'linux', jdk: 11],
+ [platform: 'windows', jdk: 11],
+])
diff --git a/build.gradle b/build.gradle
deleted file mode 100644
index 2571eb1..0000000
--- a/build.gradle
+++ /dev/null
@@ -1,99 +0,0 @@
-plugins {
- id 'org.jenkins-ci.jpi' version '0.49.0'
- id 'jacoco'
- id 'java'
-}
-
-java {
- sourceCompatibility = JavaVersion.VERSION_11
-}
-
-if (JavaVersion.current() != JavaVersion.VERSION_11) {
- throw new GradleException("Build requires Java ${JavaVersion.VERSION_11}")
-}
-
-def coreBaseVersion = '2.361'
-
-jenkinsPlugin {
- coreVersion = coreBaseVersion
- shortName = project.name
- displayName = jenkinsDisplayName
- url = "https://github.com/jenkinsci/$project.name"
- gitHubUrl = "https://github.com/jenkinsci/$project.name"
- compatibleSinceVersion = '1.20'
- fileExtension = 'hpi'
- maskClasses = 'groovy.grape'
- pluginFirstClassLoader = true
- developers {
- developer {
- id 'nickg'
- name 'Nick Grealy'
- email 'nickgrealy@gmail.com'
- }
- }
-}
-
-dependencies {
- implementation 'org.codehaus.groovy:groovy-all:2.4.21' // add the Groovy lib to the plugin to make @Grab work
- implementation 'org.apache.ivy:ivy:2.4.0' // required for @Grab
-
- testImplementation 'io.cucumber:cucumber-junit:7.14.0'
- testImplementation 'io.cucumber:cucumber-java:7.14.0'
- testImplementation 'org.codehaus.groovy.modules.http-builder:http-builder:0.7.1'
-
- testRuntimeOnly("org.jenkins-ci.main:jenkins-war:${coreBaseVersion}")
-}
-
-defaultTasks 'clean', 'jpi'
-
-clean {
- delete 'work', "bin"
-}
-
-tasks.register('deleteTarget', Delete) {
- delete 'target', 'out', 'work', "bin"
-}
-
-jacocoTestReport {
- reports {
- xml.required
- html.required
- }
-}
-
-check.dependsOn jacocoTestReport
-
-// Integration Test Structure
-test {
- exclude '**/integration/**'
- reports {
- junitXml.required
- html.required
- }
-}
-
-tasks.register('integTest', Test) {
- dependsOn = [jpi, test]
- testClassesDirs = sourceSets.test.output.classesDirs
- classpath = sourceSets.test.runtimeClasspath
- include '**/integration/**'
- outputs.upToDateWhen { false }
- reports {
- junitXml.required
- html.required
- }
-}
-
-check.dependsOn 'integTest'
-
-tasks.withType(Test) {
- testLogging {
- exceptionFormat = 'full'
- }
-}
-
-clean.dependsOn deleteTarget
-
-wrapper {
- gradleVersion = '8.4'
-}
diff --git a/gradle.properties b/gradle.properties
deleted file mode 100644
index 9ceb191..0000000
--- a/gradle.properties
+++ /dev/null
@@ -1,6 +0,0 @@
-group = org.jenkins-ci.plugins
-name = groovy-events-listener-plugin
-description = A Jenkins plugin, which executes groovy code when an event occurs.
-version = 1.015-SNAPSHOT
-
-jenkinsDisplayName = Groovy Events Listener Plugin
diff --git a/gradle/wrapper/gradle-wrapper.jar b/gradle/wrapper/gradle-wrapper.jar
deleted file mode 100644
index 41d9927..0000000
Binary files a/gradle/wrapper/gradle-wrapper.jar and /dev/null differ
diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties
deleted file mode 100644
index e411586..0000000
--- a/gradle/wrapper/gradle-wrapper.properties
+++ /dev/null
@@ -1,5 +0,0 @@
-distributionBase=GRADLE_USER_HOME
-distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-bin.zip
-zipStoreBase=GRADLE_USER_HOME
-zipStorePath=wrapper/dists
diff --git a/gradlew b/gradlew
deleted file mode 100755
index 1b6c787..0000000
--- a/gradlew
+++ /dev/null
@@ -1,234 +0,0 @@
-#!/bin/sh
-
-#
-# Copyright © 2015-2021 the original authors.
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# https://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-##############################################################################
-#
-# Gradle start up script for POSIX generated by Gradle.
-#
-# Important for running:
-#
-# (1) You need a POSIX-compliant shell to run this script. If your /bin/sh is
-# noncompliant, but you have some other compliant shell such as ksh or
-# bash, then to run this script, type that shell name before the whole
-# command line, like:
-#
-# ksh Gradle
-#
-# Busybox and similar reduced shells will NOT work, because this script
-# requires all of these POSIX shell features:
-# * functions;
-# * expansions «$var», «${var}», «${var:-default}», «${var+SET}»,
-# «${var#prefix}», «${var%suffix}», and «$( cmd )»;
-# * compound commands having a testable exit status, especially «case»;
-# * various built-in commands including «command», «set», and «ulimit».
-#
-# Important for patching:
-#
-# (2) This script targets any POSIX shell, so it avoids extensions provided
-# by Bash, Ksh, etc; in particular arrays are avoided.
-#
-# The "traditional" practice of packing multiple parameters into a
-# space-separated string is a well documented source of bugs and security
-# problems, so this is (mostly) avoided, by progressively accumulating
-# options in "$@", and eventually passing that to Java.
-#
-# Where the inherited environment variables (DEFAULT_JVM_OPTS, JAVA_OPTS,
-# and GRADLE_OPTS) rely on word-splitting, this is performed explicitly;
-# see the in-line comments for details.
-#
-# There are tweaks for specific operating systems such as AIX, CygWin,
-# Darwin, MinGW, and NonStop.
-#
-# (3) This script is generated from the Groovy template
-# https://github.com/gradle/gradle/blob/master/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt
-# within the Gradle project.
-#
-# You can find Gradle at https://github.com/gradle/gradle/.
-#
-##############################################################################
-
-# Attempt to set APP_HOME
-
-# Resolve links: $0 may be a link
-app_path=$0
-
-# Need this for daisy-chained symlinks.
-while
- APP_HOME=${app_path%"${app_path##*/}"} # leaves a trailing /; empty if no leading path
- [ -h "$app_path" ]
-do
- ls=$( ls -ld "$app_path" )
- link=${ls#*' -> '}
- case $link in #(
- /*) app_path=$link ;; #(
- *) app_path=$APP_HOME$link ;;
- esac
-done
-
-APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit
-
-APP_NAME="Gradle"
-APP_BASE_NAME=${0##*/}
-
-# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
-DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
-
-# Use the maximum available, or set MAX_FD != -1 to use that value.
-MAX_FD=maximum
-
-warn () {
- echo "$*"
-} >&2
-
-die () {
- echo
- echo "$*"
- echo
- exit 1
-} >&2
-
-# OS specific support (must be 'true' or 'false').
-cygwin=false
-msys=false
-darwin=false
-nonstop=false
-case "$( uname )" in #(
- CYGWIN* ) cygwin=true ;; #(
- Darwin* ) darwin=true ;; #(
- MSYS* | MINGW* ) msys=true ;; #(
- NONSTOP* ) nonstop=true ;;
-esac
-
-CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar
-
-
-# Determine the Java command to use to start the JVM.
-if [ -n "$JAVA_HOME" ] ; then
- if [ -x "$JAVA_HOME/jre/sh/java" ] ; then
- # IBM's JDK on AIX uses strange locations for the executables
- JAVACMD=$JAVA_HOME/jre/sh/java
- else
- JAVACMD=$JAVA_HOME/bin/java
- fi
- if [ ! -x "$JAVACMD" ] ; then
- die "ERROR: JAVA_HOME is set to an invalid directory: $JAVA_HOME
-
-Please set the JAVA_HOME variable in your environment to match the
-location of your Java installation."
- fi
-else
- JAVACMD=java
- which java >/dev/null 2>&1 || die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
-
-Please set the JAVA_HOME variable in your environment to match the
-location of your Java installation."
-fi
-
-# Increase the maximum file descriptors if we can.
-if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then
- case $MAX_FD in #(
- max*)
- MAX_FD=$( ulimit -H -n ) ||
- warn "Could not query maximum file descriptor limit"
- esac
- case $MAX_FD in #(
- '' | soft) :;; #(
- *)
- ulimit -n "$MAX_FD" ||
- warn "Could not set maximum file descriptor limit to $MAX_FD"
- esac
-fi
-
-# Collect all arguments for the java command, stacking in reverse order:
-# * args from the command line
-# * the main class name
-# * -classpath
-# * -D...appname settings
-# * --module-path (only if needed)
-# * DEFAULT_JVM_OPTS, JAVA_OPTS, and GRADLE_OPTS environment variables.
-
-# For Cygwin or MSYS, switch paths to Windows format before running java
-if "$cygwin" || "$msys" ; then
- APP_HOME=$( cygpath --path --mixed "$APP_HOME" )
- CLASSPATH=$( cygpath --path --mixed "$CLASSPATH" )
-
- JAVACMD=$( cygpath --unix "$JAVACMD" )
-
- # Now convert the arguments - kludge to limit ourselves to /bin/sh
- for arg do
- if
- case $arg in #(
- -*) false ;; # don't mess with options #(
- /?*) t=${arg#/} t=/${t%%/*} # looks like a POSIX filepath
- [ -e "$t" ] ;; #(
- *) false ;;
- esac
- then
- arg=$( cygpath --path --ignore --mixed "$arg" )
- fi
- # Roll the args list around exactly as many times as the number of
- # args, so each arg winds up back in the position where it started, but
- # possibly modified.
- #
- # NB: a `for` loop captures its iteration list before it begins, so
- # changing the positional parameters here affects neither the number of
- # iterations, nor the values presented in `arg`.
- shift # remove old arg
- set -- "$@" "$arg" # push replacement arg
- done
-fi
-
-# Collect all arguments for the java command;
-# * $DEFAULT_JVM_OPTS, $JAVA_OPTS, and $GRADLE_OPTS can contain fragments of
-# shell script including quotes and variable substitutions, so put them in
-# double quotes to make sure that they get re-expanded; and
-# * put everything else in single quotes, so that it's not re-expanded.
-
-set -- \
- "-Dorg.gradle.appname=$APP_BASE_NAME" \
- -classpath "$CLASSPATH" \
- org.gradle.wrapper.GradleWrapperMain \
- "$@"
-
-# Use "xargs" to parse quoted args.
-#
-# With -n1 it outputs one arg per line, with the quotes and backslashes removed.
-#
-# In Bash we could simply go:
-#
-# readarray ARGS < <( xargs -n1 <<<"$var" ) &&
-# set -- "${ARGS[@]}" "$@"
-#
-# but POSIX shell has neither arrays nor command substitution, so instead we
-# post-process each arg (as a line of input to sed) to backslash-escape any
-# character that might be a shell metacharacter, then use eval to reverse
-# that process (while maintaining the separation between arguments), and wrap
-# the whole thing up as a single "set" statement.
-#
-# This will of course break if any of these variables contains a newline or
-# an unmatched quote.
-#
-
-eval "set -- $(
- printf '%s\n' "$DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS" |
- xargs -n1 |
- sed ' s~[^-[:alnum:]+,./:=@_]~\\&~g; ' |
- tr '\n' ' '
- )" '"$@"'
-
-exec "$JAVACMD" "$@"
diff --git a/gradlew.bat b/gradlew.bat
deleted file mode 100644
index ac1b06f..0000000
--- a/gradlew.bat
+++ /dev/null
@@ -1,89 +0,0 @@
-@rem
-@rem Copyright 2015 the original author or authors.
-@rem
-@rem Licensed under the Apache License, Version 2.0 (the "License");
-@rem you may not use this file except in compliance with the License.
-@rem You may obtain a copy of the License at
-@rem
-@rem https://www.apache.org/licenses/LICENSE-2.0
-@rem
-@rem Unless required by applicable law or agreed to in writing, software
-@rem distributed under the License is distributed on an "AS IS" BASIS,
-@rem WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-@rem See the License for the specific language governing permissions and
-@rem limitations under the License.
-@rem
-
-@if "%DEBUG%" == "" @echo off
-@rem ##########################################################################
-@rem
-@rem Gradle startup script for Windows
-@rem
-@rem ##########################################################################
-
-@rem Set local scope for the variables with windows NT shell
-if "%OS%"=="Windows_NT" setlocal
-
-set DIRNAME=%~dp0
-if "%DIRNAME%" == "" set DIRNAME=.
-set APP_BASE_NAME=%~n0
-set APP_HOME=%DIRNAME%
-
-@rem Resolve any "." and ".." in APP_HOME to make it shorter.
-for %%i in ("%APP_HOME%") do set APP_HOME=%%~fi
-
-@rem Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
-set DEFAULT_JVM_OPTS="-Xmx64m" "-Xms64m"
-
-@rem Find java.exe
-if defined JAVA_HOME goto findJavaFromJavaHome
-
-set JAVA_EXE=java.exe
-%JAVA_EXE% -version >NUL 2>&1
-if "%ERRORLEVEL%" == "0" goto execute
-
-echo.
-echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
-echo.
-echo Please set the JAVA_HOME variable in your environment to match the
-echo location of your Java installation.
-
-goto fail
-
-:findJavaFromJavaHome
-set JAVA_HOME=%JAVA_HOME:"=%
-set JAVA_EXE=%JAVA_HOME%/bin/java.exe
-
-if exist "%JAVA_EXE%" goto execute
-
-echo.
-echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME%
-echo.
-echo Please set the JAVA_HOME variable in your environment to match the
-echo location of your Java installation.
-
-goto fail
-
-:execute
-@rem Setup the command line
-
-set CLASSPATH=%APP_HOME%\gradle\wrapper\gradle-wrapper.jar
-
-
-@rem Execute Gradle
-"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %*
-
-:end
-@rem End local scope for the variables with windows NT shell
-if "%ERRORLEVEL%"=="0" goto mainEnd
-
-:fail
-rem Set variable GRADLE_EXIT_CONSOLE if you need the _script_ return code instead of
-rem the _cmd.exe /c_ return code!
-if not "" == "%GRADLE_EXIT_CONSOLE%" exit 1
-exit /b 1
-
-:mainEnd
-if "%OS%"=="Windows_NT" endlocal
-
-:omega
diff --git a/pom.xml b/pom.xml
new file mode 100644
index 0000000..755edb5
--- /dev/null
+++ b/pom.xml
@@ -0,0 +1,140 @@
+
+
+ 4.0.0
+
+ org.jenkins-ci.plugins
+ plugin
+ 4.74
+
+
+
+ groovy-events-listener-plugin
+ ${revision}${changelist}
+ hpi
+ Groovy Events Listener Plugin
+ https://github.com/jenkinsci/${project.artifactId}
+
+
+
+ MIT License
+ https://opensource.org/license/mit/
+
+
+
+
+
+ nickg
+ Nick Grealy
+ nickgrealy@gmail.com
+
+
+
+
+ scm:git:https://github.com/${gitHubRepo}.git
+ scm:git:git@github.com:${gitHubRepo}.git
+ ${scmTag}
+ https://github.com/${gitHubRepo}
+
+
+
+ 1.020
+ -SNAPSHOT
+
+ 2.387.3
+ jenkinsci/${project.artifactId}
+
+ true
+
+ High
+
+
+
+
+
+ io.jenkins.tools.bom
+ bom-2.387.x
+ 2507.vcb_18c56b_f57c
+ pom
+ import
+
+
+
+
+
+
+
+ org.apache.ivy
+ ivy
+ 2.4.0
+
+
+
+ org.codehaus.groovy
+ groovy-all
+ 2.4.21
+
+
+ io.cucumber
+ cucumber-java
+ 7.14.0
+ test
+
+
+ io.cucumber
+ cucumber-junit
+ 7.14.0
+ test
+
+
+ org.codehaus.groovy.modules.http-builder
+ http-builder
+ 0.7.1
+ test
+
+
+
+
+
+ repo.jenkins-ci.org
+ https://repo.jenkins-ci.org/public/
+
+
+
+
+
+ repo.jenkins-ci.org
+ https://repo.jenkins-ci.org/public/
+
+
+
+
+
+
+ org.codehaus.gmavenplus
+ gmavenplus-plugin
+
+
+
+ addSources
+ addTestSources
+ generateStubs
+ compile
+ generateTestStubs
+ compileTests
+ removeStubs
+ removeTestStubs
+
+
+
+
+
+ org.jenkins-ci.tools
+ maven-hpi-plugin
+
+ groovy.grape
+ true
+
+
+
+
+
diff --git a/settings.gradle b/settings.gradle
deleted file mode 100644
index 164c271..0000000
--- a/settings.gradle
+++ /dev/null
@@ -1 +0,0 @@
-rootProject.name = 'groovy-events-listener-plugin'
diff --git a/src/main/groovy/org/jenkinsci/plugins/globalEventsPlugin/GlobalComputerListener.java b/src/main/groovy/org/jenkinsci/plugins/globalEventsPlugin/GlobalComputerListener.java
index ca0a062..efd0633 100644
--- a/src/main/groovy/org/jenkinsci/plugins/globalEventsPlugin/GlobalComputerListener.java
+++ b/src/main/groovy/org/jenkinsci/plugins/globalEventsPlugin/GlobalComputerListener.java
@@ -1,5 +1,6 @@
package org.jenkinsci.plugins.globalEventsPlugin;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import hudson.Extension;
import hudson.model.Computer;
import hudson.model.TaskListener;
@@ -16,6 +17,7 @@
@Extension
public class GlobalComputerListener extends ComputerListener {
+ @SuppressFBWarnings(value = "MS_SHOULD_BE_FINAL", justification = "Needs to be overridden from tests")
protected static Logger log = Logger.getLogger(GlobalComputerListener.class.getName());
/**
diff --git a/src/main/groovy/org/jenkinsci/plugins/globalEventsPlugin/GlobalItemListener.java b/src/main/groovy/org/jenkinsci/plugins/globalEventsPlugin/GlobalItemListener.java
index 162e05f..137c5ea 100644
--- a/src/main/groovy/org/jenkinsci/plugins/globalEventsPlugin/GlobalItemListener.java
+++ b/src/main/groovy/org/jenkinsci/plugins/globalEventsPlugin/GlobalItemListener.java
@@ -1,5 +1,6 @@
package org.jenkinsci.plugins.globalEventsPlugin;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import hudson.Extension;
import hudson.model.Item;
import hudson.model.listeners.ItemListener;
@@ -11,6 +12,7 @@
@Extension
public class GlobalItemListener extends ItemListener {
+ @SuppressFBWarnings(value = "MS_SHOULD_BE_FINAL", justification = "Needs to be overridden from tests")
protected static Logger log = Logger.getLogger(GlobalItemListener.class.getName());
public GlobalItemListener() {
diff --git a/src/main/groovy/org/jenkinsci/plugins/globalEventsPlugin/GlobalQueueListener.java b/src/main/groovy/org/jenkinsci/plugins/globalEventsPlugin/GlobalQueueListener.java
index cb4e8e5..0573340 100644
--- a/src/main/groovy/org/jenkinsci/plugins/globalEventsPlugin/GlobalQueueListener.java
+++ b/src/main/groovy/org/jenkinsci/plugins/globalEventsPlugin/GlobalQueueListener.java
@@ -1,5 +1,6 @@
package org.jenkinsci.plugins.globalEventsPlugin;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import hudson.Extension;
import hudson.model.Queue.BlockedItem;
import hudson.model.Queue.BuildableItem;
@@ -17,6 +18,7 @@
@Extension
public class GlobalQueueListener extends QueueListener {
+ @SuppressFBWarnings(value = "MS_SHOULD_BE_FINAL", justification = "Needs to be overridden from tests")
protected static Logger log = Logger.getLogger(GlobalQueueListener.class.getName());
/**
diff --git a/src/main/groovy/org/jenkinsci/plugins/globalEventsPlugin/GlobalRunListener.java b/src/main/groovy/org/jenkinsci/plugins/globalEventsPlugin/GlobalRunListener.java
index 8275ebd..644d733 100644
--- a/src/main/groovy/org/jenkinsci/plugins/globalEventsPlugin/GlobalRunListener.java
+++ b/src/main/groovy/org/jenkinsci/plugins/globalEventsPlugin/GlobalRunListener.java
@@ -1,5 +1,6 @@
package org.jenkinsci.plugins.globalEventsPlugin;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import hudson.Extension;
import hudson.model.Run;
import hudson.model.TaskListener;
@@ -16,6 +17,7 @@
@Extension
public class GlobalRunListener extends RunListener {
+ @SuppressFBWarnings(value = "MS_SHOULD_BE_FINAL", justification = "Needs to be overridden from tests")
protected static Logger log = Logger.getLogger(GlobalRunListener.class.getName());
/**