Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider rollback jenkins configurations and mark them as deprecated #149

Closed
rpalcolea opened this issue Mar 2, 2020 · 6 comments · Fixed by #150
Closed

Consider rollback jenkins configurations and mark them as deprecated #149

rpalcolea opened this issue Mar 2, 2020 · 6 comments · Fixed by #150

Comments

@rpalcolea
Copy link

rpalcolea commented Mar 2, 2020

Hi folks,

I was looking at removals for the next version:

Removed
jenkinsPlugins configuration (use implementation)
optionalJenkinsPlugins configuration (use Gradle feature variants)
jenkinsTest configuration (use testImplementation)

Wondering if this could be added back and extend those configurations instead and have them as deprecated for a while so folks can move on their own pace instead of introducing the breaking change?

Thoughts? // cc @rahulsom

@sghill
Copy link

sghill commented Mar 2, 2020

Definitely worth considering @rpalcolea. The change in optionalJenkinsPlugins doesn’t have a straightforward path forward without breaking, but the other two do. The original discussion was here: #132 (comment)

Discovering the impact of this breaking change was mentioned here as a reason to publish the candidates before making a decision on releasing: #132 (comment)

One other option is if it’s simpler/faster to define the configuration inheritance in an intermediate plugin.

@rahulsom
Copy link

rahulsom commented Mar 3, 2020

The warning idea sounds good, but this is a 0.x plugin, so I wouldn't want to burden it with having to maintain backwards compatibility. I wonder if there is a way to break the build and explain the new approach at the same time...

@rpalcolea
Copy link
Author

configurations could be restored but fail the build when used

@wolfs
Copy link
Member

wolfs commented Mar 3, 2020

configurations could be restored but fail the build when used

I don't see this a big improvement, given that in the current state the build fails as well.

Regarding backwards compatibility: The RC candidate currently only works on Gradle 6.0. Is this also a problem? Or is it enough to have the old configurations working for a few more releases until they are removed?

@rpalcolea
Copy link
Author

It is more of a migration other than gradle compatibility + error messaging could be more helpful than configuration not found, with plugin specifics on how to migrate

@rpalcolea
Copy link
Author

This is what I had in mind: #150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants