-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider rollback jenkins configurations and mark them as deprecated #149
Comments
Definitely worth considering @rpalcolea. The change in Discovering the impact of this breaking change was mentioned here as a reason to publish the candidates before making a decision on releasing: #132 (comment) One other option is if it’s simpler/faster to define the configuration inheritance in an intermediate plugin. |
The warning idea sounds good, but this is a 0.x plugin, so I wouldn't want to burden it with having to maintain backwards compatibility. I wonder if there is a way to break the build and explain the new approach at the same time... |
configurations could be restored but fail the build when used |
I don't see this a big improvement, given that in the current state the build fails as well. Regarding backwards compatibility: The RC candidate currently only works on Gradle 6.0. Is this also a problem? Or is it enough to have the old configurations working for a few more releases until they are removed? |
It is more of a migration other than gradle compatibility + error messaging could be more helpful than configuration not found, with plugin specifics on how to migrate |
This is what I had in mind: #150 |
Hi folks,
I was looking at removals for the next version:
Wondering if this could be added back and extend those configurations instead and have them as deprecated for a while so folks can move on their own pace instead of introducing the breaking change?
Thoughts? // cc @rahulsom
The text was updated successfully, but these errors were encountered: