-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support all the glob formats for the download step #109
base: develop
Are you sure you want to change the base?
Conversation
80f0fdf
to
b2f8571
Compare
@@ -21,7 +21,8 @@ pipeline { | |||
steps{ | |||
step([$class: 'DownloadStep', credentialsId: env | |||
.CREDENTIALS_ID, bucketUri: "gs://${env.BUCKET}/${env.PATTERN}", | |||
localDirectory: "${env.DIR}/**/*"]) | |||
localDirectory: "${env.DIR}"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
localDirectory
requires path relative to the workspace, so wildcards are treated as folders though.
VirtualFile archivedFile = run.getArtifactManager().root().child("folder/foo.txt"); | ||
assertTrue(archivedFile.exists()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This particular assert is similar to the ones used in other projects:
VirtualFile archivedFile = run.getArtifactManager().root().child(pattern); | ||
assertTrue(archivedFile.exists()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This particular assert is similar to the ones used in other projects:
Closes #45
### What
Add support for the multiple wildcards, aka using Glob format for the download step
Why
Missing functionality to download subfolders and nested files/folders
Tasks
mvn hpi:run
and manually created seems to works as expected.