Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: make configurable status check on coverage drop or add a kind of "tollerance" #84

Open
kmos opened this issue Apr 28, 2020 · 1 comment

Comments

@kmos
Copy link

kmos commented Apr 28, 2020

Hi,

First, thanks a lot for your work in this plugin, it's very useful for my organization even if code coverage reporting is a stressful topic.

I noticed that from version 2.1.1, is present the possibility to

Fail the status check when the coverage decreased

which is great and a fair point of discussion for the proposed code in PR but sometimes the report show something like that:

9695c93b-4837-4f9c-9e21-f88660ff1e75

which generate a bit of confusion and some awful discussion. I think that the reported value is truncated but the status check is evaluated with the complete value. Maybe a solution could be:

  • evaluate the status with the same value reported in the PR
  • add the possibility to disable the commit status or configure a tollerance value in which the status check is successful or failed.

Again thanks a lot for your work!

@isokolovskii
Copy link

Agreed, such coverage changes like <1.00% are annoying
Would be great to have possibility to set some threshold in percents for which coverage change is satisfied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants