From a0567d6b9cb98752b0ef7de2fa7e51cf25e1d2c4 Mon Sep 17 00:00:00 2001 From: Stephen Connolly Date: Thu, 9 Feb 2017 17:01:14 +0000 Subject: [PATCH] [JENKINS-41811] We don't need no GitHubTrigger2 interface --- .../cloudbees/jenkins/GitHubPushTrigger.java | 2 +- .../com/cloudbees/jenkins/GitHubTrigger.java | 2 +- .../com/cloudbees/jenkins/GitHubTrigger2.java | 18 ------------------ 3 files changed, 2 insertions(+), 20 deletions(-) delete mode 100644 src/main/java/com/cloudbees/jenkins/GitHubTrigger2.java diff --git a/src/main/java/com/cloudbees/jenkins/GitHubPushTrigger.java b/src/main/java/com/cloudbees/jenkins/GitHubPushTrigger.java index 32c33c496..d33cb112f 100644 --- a/src/main/java/com/cloudbees/jenkins/GitHubPushTrigger.java +++ b/src/main/java/com/cloudbees/jenkins/GitHubPushTrigger.java @@ -59,7 +59,7 @@ * * @author Kohsuke Kawaguchi */ -public class GitHubPushTrigger extends Trigger> implements GitHubTrigger2 { +public class GitHubPushTrigger extends Trigger> implements GitHubTrigger { @DataBoundConstructor public GitHubPushTrigger() { diff --git a/src/main/java/com/cloudbees/jenkins/GitHubTrigger.java b/src/main/java/com/cloudbees/jenkins/GitHubTrigger.java index a9fbc9cd3..9d44eb838 100644 --- a/src/main/java/com/cloudbees/jenkins/GitHubTrigger.java +++ b/src/main/java/com/cloudbees/jenkins/GitHubTrigger.java @@ -15,7 +15,7 @@ * and triggers a build. * * @author aaronwalker - * @deprecated extend {@link GitHubTrigger2} instead + * @deprecated not used any more */ public interface GitHubTrigger { diff --git a/src/main/java/com/cloudbees/jenkins/GitHubTrigger2.java b/src/main/java/com/cloudbees/jenkins/GitHubTrigger2.java deleted file mode 100644 index 717efa7b5..000000000 --- a/src/main/java/com/cloudbees/jenkins/GitHubTrigger2.java +++ /dev/null @@ -1,18 +0,0 @@ -package com.cloudbees.jenkins; - -import hudson.triggers.Trigger; - -/** - * Optional interface that can be implemented by {@link Trigger} that watches out for a change in GitHub - * and triggers a build. - * - * @author aaronwalker - */ -public interface GitHubTrigger2 extends GitHubTrigger { - - /** - * Callback to notify when a change in GitHub triggeres a build. - * @param event the event details. - */ - void onPost(GitHubTriggerEvent event); -}