Resubmitted build uses the parameters of the last build instead of the failed build

[benipeled]

Issue Details

In case of spot termination, a new build is submitted with the last build parameters

ec2-fleet-plugin/src/main/java/com/amazon/jenkins/ec2fleet/EC2FleetAutoResubmitComputerLauncher.java

Lines 103 to 106 in 93a0317

	if (task instanceof WorkflowJob) {
	final WorkflowRun failedBuild = ((WorkflowJob) task).getLastBuild();
	actions.addAll(failedBuild.getActions(ParametersAction.class));
	}

But... in the case of multiple builds, the last one is not necessarily the build that should be rebuilt, which causes the resubmitted job uses incorrect parameters.

To Reproduce

1. Trigger a workflow job with parameters
2. Trigger another workflow job with parameters
3. Terminate the instance used for the 1st build - a new build should be added to the queue
4. Check the new build parameters - it will be the 2nd build parameters instead of the 1st one.

Environment Details

Plugin Version?
2.5.1

Jenkins Version?
2.343

Spot Fleet or ASG?
Spot Fleet

Label based fleet?
Yes

Linux or Windows?
Linux

[sebek64]

I've seen the same issue. Basically, without this being fixed, spot workers with auto-retry are usable only for non-parameterized builds. For anything more sophisticated like pull-requests checks, you cannot rely on it. Any chance this will be fixed? Or should I just provide a patch?

[sebek64]

As already written in the original report, the problem is on this line:

ec2-fleet-plugin/src/main/java/com/amazon/jenkins/ec2fleet/EC2FleetAutoResubmitComputerLauncher.java

Line 104 in 8bfcdf4

final WorkflowRun failedBuild = ((WorkflowJob) task).getLastBuild();

One can call getLastFailedBuild instead of getLastBuild, that would work better in some cases, but it is not perfect either. To me, it seems that jenkins api doesn't provide the means to properly resubmit the failed job.

[benipeled]

@naraharip2017, @pdk27 thanks for the work done on efbed25 but I believe we should reopen this issue since it's not resolved the described issue,

The getLastFailedBuild() fixed will work only in the case of two builds while in our case it might be 10 different builds running in parallel (maybe I should've clarified that above) and the last failure might be a later job and not the one with the spot-termination event,

In addition, in our case, spot-termination marks the pipeline as ABORTED and not FAILURE which I'm not sure if it's caught by the getLastFailedBuild() function,

IMO, the resubmit feature should look for the exact fail-build, gather the parameters, and trigger a new one with those parameters, WDYT?