Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job Run page - "Keep this build ..." form has bg-color:white #97

Closed
fred-vogt opened this issue Jun 20, 2020 · 3 comments · Fixed by jenkinsci/jenkins#4814
Closed

Job Run page - "Keep this build ..." form has bg-color:white #97

fred-vogt opened this issue Jun 20, 2020 · 3 comments · Fixed by jenkinsci/jenkins#4814

Comments

@fred-vogt
Copy link

Been testing with this plugin. Its working great.

But this stands out on the Job Run details page:
jenkins-keep-this-build-2020-06-19 19-26-05

<div style="float:right; background-color:white; z-index: 1; position:relative; margin-left: 1em">
  <form method="post" action="toggleLogKeep" style="margin-top:1em">
    <span class="yui-button yui-submit-button submit-button primary" id="yui-gen6" name="Submit">
      <span class="first-child">
        <button type="button" tabindex="0" id="yui-gen6-button">Keep this build forever</button>
      </span>
    </span>
...
  </form>
  <div style="margin-top:1em">Started 24 sec ago</div>
  <div>Took <a href="/job/{org}/job/{repo}/job/master/buildTimeTrend">11 sec</a></div>
</div>
@timja
Copy link
Member

timja commented Jun 20, 2020

Thanks, it just needs the background-color: white removed

@fred-vogt
Copy link
Author

fred-vogt commented Jun 20, 2020

@timja - looks like this has to be done in core.

Fun fact - this is the only use of background-color:\s*white in UI pages that isn't set with CSS

jenkins$ grep -rIn 'background-color:white' * | grep -v css
core/src/main/resources/hudson/model/AbstractBuild/index.jelly:31:
    <div style="float:right; background-color:white; z-index: 1; position:relative; margin-left: 1em">
...

Screen Shot 2020-06-20 at 00 35 02

@timja
Copy link
Member

timja commented Jun 20, 2020

Yup feel free to remove it, completely unneeded and weird that it’s there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants