Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on workflow-support instead of workflow-job #94

Merged
merged 3 commits into from
Mar 17, 2021

Conversation

rsandell
Copy link
Member

Better to just use the workflow-support api instead of depending on the higher level workflow-job

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Better to just use the workflow-support api
@rsandell
Copy link
Member Author

@rsandell
Copy link
Member Author

The unit test that is failing works locally for me, and seems to work on ci.jenkins.io as well. There is something wrong with the GitHub Action's CI build.

@batmat batmat requested a review from timja March 17, 2021 10:10
@timja timja added the enhancement New feature or request label Mar 17, 2021
@XiongKezhi XiongKezhi merged commit 0438fd3 into jenkinsci:master Mar 17, 2021
@batmat
Copy link
Member

batmat commented Mar 17, 2021

Thanks a bunch for merging @XiongKezhi !

Could you please consider releasing this?

I guess it could be a 1.6.1 given this is a small adjustment on top of #66? Anyway, you'll decide.

Thanks a lot!

@XiongKezhi
Copy link
Contributor

@batmat released it in https://github.com/jenkinsci/checks-api-plugin/releases/tag/v1.6.1

@rsandell rsandell deleted the no-workflow-job branch March 17, 2021 14:12
@batmat
Copy link
Member

batmat commented Mar 17, 2021

You rock! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants