-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency on workflow-support instead of workflow-job #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better to just use the workflow-support api
jtnord
approved these changes
Mar 16, 2021
MRamonLeon
approved these changes
Mar 16, 2021
The unit test that is failing works locally for me, and seems to work on ci.jenkins.io as well. There is something wrong with the GitHub Action's CI build. |
oleg-nenashev
approved these changes
Mar 16, 2021
jglick
approved these changes
Mar 16, 2021
timja
reviewed
Mar 16, 2021
src/main/java/io/jenkins/plugins/checks/status/BuildStatusChecksPublisher.java
Outdated
Show resolved
Hide resolved
timja
approved these changes
Mar 17, 2021
XiongKezhi
approved these changes
Mar 17, 2021
Thanks a bunch for merging @XiongKezhi ! Could you please consider releasing this? I guess it could be a 1.6.1 given this is a small adjustment on top of #66? Anyway, you'll decide. Thanks a lot! |
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better to just use the workflow-support api instead of depending on the higher level workflow-job