Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trivial pmd warnings #86

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Fix trivial pmd warnings #86

merged 2 commits into from
Feb 23, 2021

Conversation

XiongKezhi
Copy link
Contributor

@XiongKezhi XiongKezhi commented Feb 23, 2021

We missed some warnings when adding FlowExecutionAnalyzer, it's better to fix them.

@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #86 (b20c9f5) into master (2933c6b) will decrease coverage by 0.09%.
The diff coverage is 55.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #86      +/-   ##
============================================
- Coverage     87.21%   87.11%   -0.10%     
  Complexity      142      142              
============================================
  Files            16       16              
  Lines           649      652       +3     
  Branches         49       49              
============================================
+ Hits            566      568       +2     
- Misses           65       66       +1     
  Partials         18       18              
Impacted Files Coverage Δ Complexity Δ
.../checks/status/AbstractStatusChecksProperties.java 50.00% <ø> (ø) 1.00 <0.00> (ø)
...s/plugins/checks/status/FlowExecutionAnalyzer.java 80.41% <55.55%> (-0.30%) 44.00 <2.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2933c6b...b20c9f5. Read the comment docs.

@XiongKezhi XiongKezhi requested a review from timja February 23, 2021 06:55
@mrginglymus
Copy link
Contributor

Oops, sorry! I’m too used to zero tolerance static analysis...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants