Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Java 17 and 2.475; adapt test suite to EE 9 #137

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

basil
Copy link
Member

@basil basil commented Aug 29, 2024

Allow this plugin's test suite to be exercised regularly in Plugin Compatibility Tester (PCT) in https://github.com/jenkinsci/bom by requiring Java 17 or newer and Jenkins 2.475 (released today) or newer.

This PR goes against the usual advice from https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ by requiring a weekly release. The advantage is that this will allow plugin compatibility testing (PCT). The disadvantage is that new features and bug fixes can't be released to LTS users for another few months.

The choice is up to the maintainer as to whether or not to accept this PR. If this PR is rejected, we will stop testing this plugin in PCT.

@basil basil marked this pull request as ready for review September 4, 2024 14:13
@basil basil requested a review from a team as a code owner September 4, 2024 14:13
@basil basil changed the title Adapt to EE 9 Adapt test suite to EE 9 Sep 4, 2024
@basil basil changed the title Adapt test suite to EE 9 Require Java 17 and 2.475; adapt test suite to EE 9 Sep 4, 2024
Copy link
Contributor

@fabiodcasilva fabiodcasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@fabiodcasilva fabiodcasilva merged commit b2fa784 into jenkinsci:master Sep 4, 2024
16 checks passed
@basil basil deleted the jakarta branch September 4, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants