Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate from KES to ESO #8298

Open
ankitm123 opened this issue Jul 12, 2022 · 11 comments
Open

migrate from KES to ESO #8298

ankitm123 opened this issue Jul 12, 2022 · 11 comments
Assignees

Comments

@ankitm123
Copy link
Member

KES is in maintaince mode, and we should move to ESO instead
external-secrets/kubernetes-external-secrets#864

@ankitm123 ankitm123 self-assigned this Jul 12, 2022
@ankitm123
Copy link
Member Author

Starting the work this weekend, will update this issue with any progress/roadblock.

@lodotek
Copy link

lodotek commented Sep 12, 2022

Any branch I can follow yet?

@lodotek
Copy link

lodotek commented Dec 12, 2022

Excited to see some progress on this! 🤞

@gek0
Copy link

gek0 commented Mar 6, 2023

Any progress on this? Is it possible to plug the new Secrets provider into JX or will it break the setup/not work at the moment?

@lodotek
Copy link

lodotek commented Mar 6, 2023

@ankitm123 is this a lot harder than you initially thought or something?

@lodotek
Copy link

lodotek commented Apr 13, 2023

Too bad this project is becoming so stale :-(

@tomhobson
Copy link
Member

Hey @lodotek, we can support you developing this feature if it's something that you'd like to do 👍

@valiksb
Copy link

valiksb commented May 15, 2023

Any update on this? Not an expert in this, but if we can help, we would like to offer some time.

@theyough
Copy link

any update ?

@roulettedares
Copy link

i see 2 existing PRs
jenkins-x-plugins/jx-secret#387
jenkins-x-plugins/jx-secret#397
if i were to try and pick this up, which one looks better to start from?

@tomhobson
Copy link
Member

tomhobson commented Jan 5, 2024

Hey @joshuasimon-taulia, 397 is my pr, I was doing a full boot job conversion, changing jx secret so that we could essentially scream test and see what breaks.

Ankits pr seems to already approach what he knew would break. I started again originally because I found it hard to pickup where Ankit left off.

If you decide with 397, The main thing that I needed to do next was to update all of the tests. From KES to ESO, it seems that the structure of the secrets has changed very little, it's more about updating the tests, I think that you'll probably want to write a little go script to automatically go through and update the tests (because there is a lot of them) and I don't want you to waste your time doing it manually.

There's a couple of changes that I wanted to make, one of the big ones was making the secret generation generate a space in vault that meant that the secrets had the environment included within the path, otherwise all of the resources across the namespace share one secret (which isn't ideal)

@msvticket msvticket moved this to In progress in Public roadmap Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

No branches or pull requests

7 participants