Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask secrets in the logs #24

Open
ankitm123 opened this issue May 27, 2022 · 1 comment
Open

Mask secrets in the logs #24

ankitm123 opened this issue May 27, 2022 · 1 comment

Comments

@ankitm123
Copy link
Member

Jenkins X just shows the raw logs from the pods or the long term storage.
It can happen that the logs contain sensitive information.

These secrets should be masked in the UI logs.
Examples of secrets include

  • github (or other SCM provider) token
  • Secrets stored in kubernetes

The change should be done in the jx-pipeline repo, so that jx cli also gets the benefit of masking (as ui and cli use the same pipeline functions).

@babadofar
Copy link
Contributor

Perhaps this can help us tektoncd/pipeline#4837

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants