Add edit this page link

[timja]

We currently have:

Help us improve this page!
To propose a change submit a pull request to the plugin page on GitHub.

It would be good to add an 'Edit this page' or 'Improve this page' link next to report a problem so you can go directly to the GitHub edit page screen from the plugin site

[Chandu-4444]

Can I do this? @timja

[zbynek]

if the goal is just to have the same link in two places, this should be quite straightforward. If we want the actual link for editing the readme, the hard part is to figure out which file it is -- it may be README.md / README.txt / README.adoc, not sure how to efficiently get it from GitHub API. Also at the moment all queries to GH API are in the plugin-site-api repository.

[RiyaGupta89]

@zbynek May I work on this issue?

[halkeye]

Sure, let us know if you need a hand or unable to work on it

[zbynek]

@timja do you have any idea how to get the correct link from GitHub API?

[timja]

You can get it from this:

https://api.github.com/repos/jenkinsci/theme-manager-plugin/readme?ref=master

[Harsh3341]

Any update on this issue?

[halkeye]

what update are you expecting?

[Harsh3341]

The implementation part is it needs to be done?
This issue is been old just asking if it's necessary to work on it.

[zbynek]

It's still a valid issue, IMHO not a high priority though.

The question is how to best find location of the README in repository. It's possible to do that with rest API, but that means 1 request per repository. Since plugin-site repo doesn't have credentials for GitHub API that would have to be exposed through API of some other component, such as https://github.com/jenkins-infra/docker-plugin-site-issues . One could ask GitHub developers to add it to the GraphQL API so that it can be obtained for 100 repos in one query. Or just try the 2-4 most common locations. Currently #961 implements the last approach.

[nouralmulhem]

is this still to be done? if so let me know where i can found Help us improve this page!